Skip to content

Possible error in build instructions in CONTRIBUTING.md #426

@alxio

Description

@alxio

Hello,
I just tried to compile this extension according to instructions in CONTRIBUTING.md:

  • cloned the repo
  • cd vscode-hexeditor
  • runned npm install
  • runned npm run watch

I'm using node v18.15.0 and npm 9.5.0.
I got following errors:

> hexeditor@1.9.11 watch
> node .esbuild.config.js --watch
X [ERROR] [plugin linaria] Unexpected token 'export' in
| C:\dev\vscode-hexeditor\node_modules\cockatiel\dist\esm\index.js
| C:\dev\vscode-hexeditor\media\editor\dataDisplayContext.tsx


    media/editor/hexEdit.tsx:7:51:
      7 │ import { DataDisplayContext, DisplayContext } from "./dataDisplayContext";
        ╵                                                    ~~~~~~~~~~~~~~~~~~~~~~

  This error came from the "onLoad" callback registered here:

    node_modules/@linaria/esbuild/lib/index.js:70:12:
      70 │       build.onLoad({
         ╵             ~~~~~~

    at setup (C:\dev\vscode-hexeditor\node_modules\@linaria\esbuild\lib\index.js:70:13)
    at handlePlugins (C:\dev\vscode-hexeditor\node_modules\esbuild\lib\main.js:1251:21)
    at buildOrServeImpl (C:\dev\vscode-hexeditor\node_modules\esbuild\lib\main.js:942:5)
    at Object.buildOrServe (C:\dev\vscode-hexeditor\node_modules\esbuild\lib\main.js:750:5)
    at C:\dev\vscode-hexeditor\node_modules\esbuild\lib\main.js:2085:17
    at new Promise (<anonymous>)
    at Object.build (C:\dev\vscode-hexeditor\node_modules\esbuild\lib\main.js:2084:14)
    at Object.build (C:\dev\vscode-hexeditor\node_modules\esbuild\lib\main.js:1931:51)
    at Object.<anonymous> (C:\dev\vscode-hexeditor\.esbuild.config.js:70:3)

Probably it's something easy to fix and the problem is in my configuration, but I'm not experienced in npm environment.

Anyway, it would be nice if instructions in CONTRIBUTING.md would contain everything needed to compile it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    duplicateThis issue or pull request already exists

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions