Update VS Code requirement to 1.65
#1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Since the lazy variable implementation is compatible with old vscode client, it's not necessary to force updating VS Code version. WDYT? |
Contributor
Author
Agree that it's not necessary, but if you run this version in an old client, you will see a similar behavior like microsoft/vscode#134450 (comment), for the getter of address. it will introduce an extra node so I'm not sure if it's a good UX. It's up to you. |
Contributor
|
@CsCherrYY Could you pls resolve the conflicts? |
CsCherrYY
force-pushed
the
cs-lazy-loading
branch
from
58b2304 to
88c7d75
Compare
testforstephen
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we will support lazy loading in microsoft/java-debug#401, the requirement of this feature is introduced in VS Code 1.65, see: https://github.com/microsoft/vscode-docs/blob/vnext/release-notes/v1_65.md#lazy-variables