Skip to content

Conversation

@andxu
Copy link
Contributor

@andxu andxu commented Sep 19, 2018

No description provided.

@andxu andxu requested a review from yaohaizh September 19, 2018 01:42
@andxu andxu mentioned this pull request Sep 19, 2018
15 tasks
CHANGELOG.md Outdated

## 0.13.0 - 2018-9-19
### Added
- Use code lens to run java program in much simpler way. [#375](https://github.com/Microsoft/vscode-java-debug/issues/375).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in a much simpler way" ?

@yaohaizh yaohaizh changed the title add change log for 0.13.0 Add change log for 0.13.0 Sep 19, 2018
Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, better let others to take a look.

CHANGELOG.md Outdated
- Fix: Still include test classes in classpaths when auto resolve maven project. [#378](https://github.com/Microsoft/vscode-java-debug/issues/378).
- Fix: Duplicate class path during launching. [#370](https://github.com/Microsoft/vscode-java-debug/issues/370).
- Fix: Update Active Editor oct icon to file instead of clock. [#403](https://github.com/Microsoft/vscode-java-debug/issues/403).
- Fix: Launching the same JDK as java language server other than JRE. [#366](https://github.com/Microsoft/vscode-java-debug/issues/366).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: Launching the debuggee with the same JDK as java language server instead of JRE.

CHANGELOG.md Outdated
- Fix: Duplicate class path during launching. [#370](https://github.com/Microsoft/vscode-java-debug/issues/370).
- Fix: Update Active Editor oct icon to file instead of clock. [#403](https://github.com/Microsoft/vscode-java-debug/issues/403).
- Fix: Launching the same JDK as java language server other than JRE. [#366](https://github.com/Microsoft/vscode-java-debug/issues/366).
- Fix: Should not pop up error window many times for logpoints in a loop. [#360](https://github.com/Microsoft/vscode-java-debug/issues/390).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not ==> Avoid

CHANGELOG.md Outdated
### Added
- Use code lens to run java program in a much simpler way. [#375](https://github.com/Microsoft/vscode-java-debug/issues/375).
- Make vmArgs accept an array. [#389](https://github.com/Microsoft/vscode-java-debug/issues/389).
- Make mainClass accept variable. [#85](https://github.com/Microsoft/vscode-java-debug/issues/85).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"accept a variable" or "accept variables" ?

CHANGELOG.md Outdated
- Fix: Still include test classes in classpaths when auto resolve maven project. [#378](https://github.com/Microsoft/vscode-java-debug/issues/378).
- Fix: Duplicate class path during launching. [#370](https://github.com/Microsoft/vscode-java-debug/issues/370).
- Fix: Update Active Editor oct icon to file instead of clock. [#403](https://github.com/Microsoft/vscode-java-debug/issues/403).
- Fix: Launching the same JDK as java language server other than JRE. [#366](https://github.com/Microsoft/vscode-java-debug/issues/366).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: Launching the same JDK as the java language server

CHANGELOG.md Outdated
## 0.13.0 - 2018-9-19
### Added
- Use code lens to run java program in a much simpler way. [#375](https://github.com/Microsoft/vscode-java-debug/issues/375).
- Make vmArgs accept an array. [#389](https://github.com/Microsoft/vscode-java-debug/issues/389).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make args/vmArgs accept an array.

@andxu andxu merged commit 5495abc into master Sep 19, 2018
@andxu andxu deleted the andy_changelog2 branch September 19, 2018 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants