test(e2e): cover classpath / referenced-libraries commands#1028
Merged
Conversation
Cover the four java.project.* classpath commands on an invisible (unmanaged-folder) project: - java.project.refreshLibraries -> Refresh inline icon, idempotent - java.project.addLibraries -> + inline icon + simpleFileDialog - java.project.removeLibrary -> include-removal branch - java.project.addLibraryFolders -> command id + Select Library Folders - java.project.removeLibrary (#2) -> exclude-addition branch Reuse the existing est/invisible fixture and the two new �xtraJars/extra-{a,b}.jar files committed earlier so all 33 steps run deterministically against the worktree workspace. Auto-discovered by the existing matrix in .github/workflows/e2eUI.yml, no CI wiring needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The previous template
file:///${workspaceFolder}/extraJars/extra-a.jar
happened to round-trip through vscode.Uri.parse(...).fsPath on Windows
(where ${workspaceFolder} is a C:\... path) but on Linux it produced
file:////home/runner/... (FOUR slashes). Uri.parse mapped that to a
//home/... path, so workspace.asRelativePath did not match the include
entry and removeLibrary silently did nothing -- both verify-extra-a-gone
and verify-extra-a-excluded then timed out on the Linux CI matrix.
Switch to the new ${workspaceFolderUri} placeholder (autotest 0.7.13),
which is backed by Node's url.pathToFileURL and produces a correctly
formed file:// URI on both Windows and POSIX.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new end-to-end UI test plan to exercise vscode-java-dependency’s referenced-library (classpath) management commands on an invisible/unmanaged Java project, including both removeLibrary handler branches.
Changes:
- Introduces
test/e2e-plans/java-dep-classpath.yamlcoveringjava.project.refreshLibraries,addLibraries,addLibraryFolders, andremoveLibrary. - Verifies referenced-library state via deterministic
verifyTreeItemassertions across multiple cycles (add/remove, glob re-attach, exclude path).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chagong
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase B: Classpath / Referenced Libraries coverage
Adds
test/e2e-plans/java-dep-classpath.yamlexercising all fourjava.project.*referenced-library commands on an invisible (unmanaged-folder) project, plus the two distinctremoveLibrarycode paths.Commands covered
java.project.refreshLibrariesRefreshinline icon on Referenced Librariesjava.project.addLibraries+inline icon -> simpleFileDialog jar pickjava.project.removeLibrary(include-removal)java.project.addLibraryFoldersSelect Library Foldersbuttonjava.project.removeLibrary(exclude-add)Notable design decisions (documented inline in the YAML)
open file src/App.javabeforewaitForLanguageServer.collapseWorkspaceRoottarget -- usecollapseSidebarSection invisibleso the JAVA PROJECTS pane gets the vertical room virtualisation needs to render jar leaves.exact: trueon jarverifyTreeItemblocks (project root keeps it).showOpenDialogforsimpleFileDialog-- drive the picker withfillQuickInput; folder pick additionally needstryClickButton Select Library Foldersbecause Enter on a folder navigates into it.removeLibraryis invoked viaexecuteVSCodeCommand-- the inline minus icon hit-target is narrower than the wrapping<li class="action-item">whose centreclickTreeItemActiontargets, so the click consistently misses on jar-leaf rows. The command id bypasses the hit-target gap and exercises the same handler.removeLibrarybranch -- after cycle 4 the folder glob re-attachesextra-a.jar; removing it again goes through theif (removedPaths.length === 0)path that appends toreferencedLibraries.exclude.Fixtures
test/invisible/extraJars/extra-a.jarandextra-b.jar(added in a prior commit on this branch) enable the add-then-remove cycles without polluting the baselinelib/simple.jar.Local verification
Auto-discovered by the existing matrix in
.github/workflows/e2eUI.ymlvia thediscover-plansjob -- no CI wiring needed.