test: enable Playwright trace on all E2E test runs#987
Merged
wenytang-ms merged 3 commits intomainfrom Apr 1, 2026
Merged
Conversation
Change trace from 'on-first-retry' to 'on' so every test run captures screenshots and DOM snapshots at each Playwright action. This makes debugging easier — especially when traces are reviewed by AI — since the full interaction flow is always available, not just on retries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Playwright tracing for all E2E test executions to make debugging easier by consistently capturing screenshots/DOM snapshots across the full interaction flow.
Changes:
- Switch Playwright
use.tracefrom"on-first-retry"to"on"in the E2E config. - Update the Electron-based
baseTestfixture to always start tracing and always persisttrace.zip.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
test/e2e/playwright.config.ts |
Enables trace capture for every test run via use.trace: "on". |
test/e2e/fixtures/baseTest.ts |
Forces tracing start/stop in the shared E2E fixture and always writes trace.zip. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Address review comments: - Use 'retain-on-failure' in CI to limit artifact size, 'on' locally - Remove manual tracing.start/stop from fixture — Playwright's built-in use.trace config handles it automatically, avoiding 'Tracing has been already started' conflicts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chagong
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change trace from \on-first-retry\ to \on\ so every test run captures screenshots and DOM snapshots at each Playwright action.
This makes debugging easier — especially when traces are reviewed by AI — since the full interaction flow is always available, not just on retries.
Changes