Skip to content

Conversation

@Eskibear
Copy link
Member

@Eskibear Eskibear commented Nov 2, 2020

Now it's split into 3 tabviews + 1 fixed panel below.

Tabviews:

  • Project JDKs: configure JDK for projects, modifying mapping of source level to JDKs.
  • Setup Lanaguage Server: configure JDK to launch LS itself.
  • Installed JDKs: an overview listing all installed JDKs and versions.

Fixed panel:

  • Install A JDK: shortcut to download a new JDK.

@Eskibear
Copy link
Member Author

Eskibear commented Nov 2, 2020

Screenshots for 3 tab views.

image

image

image

@Eskibear Eskibear force-pushed the pr branch 2 times, most recently from 35679ff to d7efa4b Compare November 2, 2020 08:26
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Member Author

Eskibear commented Nov 3, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@Eskibear
Copy link
Member Author

Eskibear commented Nov 3, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Eskibear
Copy link
Member Author

Eskibear commented Nov 3, 2020

TSLint failed because of overview page, probably introduced in previous changes. Gonna fix that first.

@jdneo
Copy link
Member

jdneo commented Nov 3, 2020

Some feedbacks after playing with the bit

  1. I find here we have too large empty space
    image
    image

  2. If user updates the language level, the configuration page will not auto refresh. Shall we listen to the onDidClasspathUpdate event?

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Member Author

Eskibear commented Nov 3, 2020

  1. I'll adjust and remove the spaces.

  2. I can give it a try. However a corner case is, when webview is open, if vscode-java extension is not yet activated, the event is invalid.

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@testforstephen
Copy link
Contributor

This is the result i got when i opened spring-petclinic project.

image

It lists both 11 and 1.8, since my project just used Java 1.8 and the description says it's Java versions detected in my projects? This is a little confusing to me, is this a bug?

@Eskibear
Copy link
Member Author

Eskibear commented Nov 3, 2020

@testforstephen Good catch. It's for the default project, which I didn't exclude from the list.

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Member Author

Eskibear commented Nov 4, 2020

@jdneo @testforstephen
Comments addressed, can you take a look/give it a try?

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
…ected

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Member Author

Eskibear commented Nov 5, 2020

I've just added Workspace Overview, to provide a straightforward view of relationship between projects and Java versions. The layout looks like below.

image

Further action items:

@testforstephen
Copy link
Contributor

Project name is fake (simply using base name of the project root folder), as we lack an API to get it.

Yeah, finally the LS should provide an API to list the project metadata. So far, you could parse name from .project file, or leverage java.project.list command exposed by Project Explorer. https://github.com/microsoft/vscode-java-dependency/blob/master/src/commands.ts

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@Eskibear
Copy link
Member Author

Changelog:

  • fetch project metadata from Project Manager, to show correct project names
  • click Maven/Gradle to open pom.xml / build.gradle
  • refine wording

Now it looks like:
image

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
@jdneo
Copy link
Member

jdneo commented Nov 17, 2020

This page can also be registered into the navigation bar of Java Projects explorer

Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after playing with the page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants