Skip to content

Migrate package TypeScript settings to ESM#2355

Merged
rzhao271 merged 1 commit into
mainfrom
copilot/change-package-to-esm
May 14, 2026
Merged

Migrate package TypeScript settings to ESM#2355
rzhao271 merged 1 commit into
mainfrom
copilot/change-package-to-esm

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

Summary

  • switch root TypeScript module settings from CommonJS/node resolution to ES2022 + bundler resolution
  • update ESM-incompatible typings/usages surfaced by the new module mode (ws server typings, localized string indexing, reporter exports)
  • keep compile/typecheck green under the ESM configuration

Validation

  • npm run compile ✅ (build succeeds; dprint plugin download warning is environment/network related)
  • npm run test:types
  • npm run test:lint ⚠️ fails in this sandbox due to blocked access to plugins.dprint.dev
  • npm run test:unit ⚠️ fails in this sandbox with missing vscode module dependency setup
  • parallel_validation ✅ (Code Review + CodeQL: no issues)

@rzhao271 rzhao271 added this to the 1.121.0 milestone May 14, 2026
@rzhao271 rzhao271 marked this pull request as ready for review May 14, 2026 23:21
@rzhao271 rzhao271 merged commit 01162cb into main May 14, 2026
7 checks passed
@rzhao271 rzhao271 deleted the copilot/change-package-to-esm branch May 14, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants