Unable to add Entra Account - reading 'id' of undefined

[wj-halfspace]

Describe the bug

After trying to add Entra Account interactively in browser the account does not appear in the dropdown list.

When adding a new connection I use Authentication type - Entra Auth. I successfully select Subsription, Resource Group, Location, Server, Database.
When adding Entra Account I am being redirected, I login, everything seems fine but I am unable to see the account in the list. In the browser i do see "Your Microsoft Entra Account was added successfully!
You may now close this page.".

To Reproduce

Steps to reproduce the behavior:

1. Start adding a new connection
2. Fill in subscription, rg, location, server, db.
3. Select authentication type - Entra Auth
4. Click "Add Entra Id" button
5. Log in in the browser.
6. The account does not appear in the dropdown.

Expected behavior

The account is added to the dropdown and I can select it.

VS Code version

Extension version: 1.10.0

Version: 1.98.2 (user setup)
Commit: ddc367ed5c8936efe395cffeec279b04ffd7db78
Date: 2025-03-12T13:32:45.399Z
Electron: 34.2.0
ElectronBuildId: 11161602
Chromium: 132.0.6834.196
Node.js: 20.18.2
V8: 13.2.152.36-electron.0
OS: Windows_NT x64 10.0.22631

Extension Logs

OUTPUT: [9:05:40 AM] [PgToolsService Initialization] [Verbose]: Retreived 1 Azure accounts from account store.

mainThreadExtensionService.ts:79 TypeError: Cannot read properties of undefined (reading 'id')
    at /home/coder/.vscode-server/extensions/ms-ossdata.vscode-pgsql-1.10.0/out/src/azure/accountStore.js:70:73
    at Array.filter (<anonymous>)
    at AccountStore.<anonymous> (/home/coder/.vscode-server/extensions/ms-ossdata.vscode-pgsql-1.10.0/out/src/azure/accountStore.js:70:49)
    at Generator.next (<anonymous>)
    at /home/coder/.vscode-server/extensions/ms-ossdata.vscode-pgsql-1.10.0/out/src/azure/accountStore.js:12:71
    at new Promise (<anonymous>)
    at __awaiter (/home/coder/.vscode-server/extensions/ms-ossdata.vscode-pgsql-1.10.0/out/src/azure/accountStore.js:8:12)
    at AccountStore.addAccount (/home/coder/.vscode-server/extensions/ms-ossdata.vscode-pgsql-1.10.0/out/src/azure/accountStore.js:65:16)
    at MsalAzureController.<anonymous> (/home/coder/.vscode-server/extensions/ms-ossdata.vscode-pgsql-1.10.0/out/src/azure/azureController.js:52:32)
    at Generator.next (<anonymous>)
    at fulfilled (/home/coder/.vscode-server/extensions/ms-ossdata.vscode-pgsql-1.10.0/out/src/azure/azureController.js:9:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)```

[mmcfarland]

Thanks for this report @wj-halfspace, appreciate including the logs as well. We'll look into this and may follow up here for additional details if we have questions.

[skoging]

I think I'm having the exact same issue. Login succeeds and I see the same Retreived 1 Azure accounts from account store. message in the logs, but the Entra account list stays empty.

[skoging]

This workaround for a similar report in MSSQL extension worked for me:

• [Bug]: Can't connect with Microsoft Entra ID vscode-mssql#19531 (comment)

1. Run PGSQL: Remove Microsoft Entra Account for each account that appears
2. Run PGSQL: Clear Microsoft Entra account token cache

For 1 - there was an account listed called undefined which I removed

I could then successfully add my account with the "Add Entra Id" button.

---

Thank you for including the logs! It seems that we weren't able to read the account metadata.

Could you try doing the following:

1. Run MSSQL: Remove Microsoft Entra Account for each account that appears
2. Run MSSQL: Clear Microsoft Entra account token cache

Then try connecting again, and supply logs from both the MSSQL and Azure Logs outputs. I'm particularly interested in the logs following something like "Fetching tenants with uri".

Be sure to replace personal information/IDs in the Azure Logs with dummy values.

[skoging]

Theres also merged PR with a fix for the mssql extension:

• Automatically prune invalid/corrupted Entra account entries in global state vscode-mssql#19959

[mmcfarland]

@skoging -- great information, thanks for digging into this.

[mmcfarland]

We've made the fix in v1.12.0 to prevent bad account values to be persisted in the account store. For any existing undefined accounts, please follow the clean out steps outlined here. Subsequent account adds should not allow you to get in a bad state.