Connections are exhausted not reused or cleaned

[craftzneko]

Describe the bug

Opening up multiple query's and closing them exceed connection pool. I am not doing this quickly but over 20 minutes

To Reproduce

Steps to reproduce the behaviour:

1. Open a few select querys on a table (right click select)
2. close them
3. Repeat until connection advises exceeds pool limit

Expected behavior

If connections are made per query they should close when the query closes or connections should be reused?

Screenshots

If applicable, add screenshots to help explain your problem.

VS Code version
1.105.1

Extension Logs

1.1.0

See: https://github.com/microsoft/vscode-pgsql?tab=readme-ov-file#usage-and-feedback

[9:11:21 AM] [ObjectExplorerService] [All]: Getting children for node '/databases/'
[9:11:23 AM] [ObjectExplorerService] [All]: Getting children for node '/databases/33630591/'
[9:11:24 AM] [ObjectExplorerService] [All]: Getting children for node '/databases/33630591/schemas/'
[9:11:25 AM] [ObjectExplorerService] [All]: Getting children for node '/databases/33630591/schemas/33630850/'
[9:11:27 AM] [ObjectExplorerService] [All]: Getting children for node '/databases/33630591/schemas/33630850/tables/'
[9:11:33 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "REDACTED.postgres.database.azure.com__REDACTED".
[9:11:33 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "REDACTED.postgres.database.azure.com__REDACTED". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:11:33 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-1".
[9:11:33 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-1". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:11:33 AM] Started query execution for document "untitled:Untitled-1"
[9:11:33 AM] [pgQueryResult] [All]: View is not ready, queuing state update for untitled:Untitled-1
[9:11:33 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:11:33 AM] [pgQueryResult] [All]: View is not ready, queuing state update for untitled:Untitled-1
[9:11:33 AM] Finished query execution for document "untitled:Untitled-1"
[9:11:33 AM] [pgQueryResult] [All]: View is not ready, queuing state update for untitled:Untitled-1
[9:11:34 AM] [pgQueryResult] [All]: resultGrid: 14
[9:11:34 AM] [pgQueryResult] [All]: QueryResultPane is ready to receive state updates
[9:11:34 AM] [pgQueryResult] [All]: Query result view is ready, checking queued state updates for 1 URIs
[9:11:34 AM] [pgQueryResult] [All]: Current active editor URI: untitled:Untitled-1
[9:11:34 AM] [pgQueryResult] [All]: Applying queued state update for URI: untitled:Untitled-1
[9:11:34 AM] [pgQueryResult] [All]: resizeGrid - table is not initialized
[9:11:34 AM] [pgQueryResult] [All]: resultGrid: 14
[9:15:51 AM] Disconnected on document "untitled:Untitled-1"
[9:21:54 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "REDACTED.postgres.database.azure.com_ictslam_REDACTED".
[9:21:54 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "REDACTED.postgres.database.azure.com_ictslam_REDACTED". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:21:54 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-1".
[9:21:54 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-1". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:21:54 AM] Started query execution for document "untitled:Untitled-1"
[9:21:55 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:21:55 AM] Finished query execution for document "untitled:Untitled-1"
[9:21:55 AM] [pgQueryResult] [All]: resultGrid: 14
[9:21:55 AM] [pgQueryResult] [All]: QueryResultPane is ready to receive state updates
[9:21:55 AM] [pgQueryResult] [All]: Query result view is ready, checking queued state updates for 0 URIs
[9:21:55 AM] [pgQueryResult] [All]: Current active editor URI: untitled:Untitled-1
[9:21:55 AM] [pgQueryResult] [All]: resizeGrid - table is not initialized
[9:21:55 AM] [pgQueryResult] [All]: resultGrid: 14
[9:21:58 AM] No need to refresh Microsoft Entra acccount token for connection -7200190148847840374 with uri untitled:Untitled-1
[9:21:58 AM] Started query execution for document "untitled:Untitled-1"
[9:21:59 AM] Finished query execution for document "untitled:Untitled-1"
[9:22:06 AM] Disconnected on document "untitled:Untitled-1"
[9:22:08 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-1".
[9:22:09 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-1". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:22:09 AM] Started query execution for document "untitled:Untitled-1"
[9:22:09 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:22:09 AM] Finished query execution for document "untitled:Untitled-1"
[9:22:09 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:11 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-2".
[9:22:11 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-2". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:22:11 AM] Started query execution for document "untitled:Untitled-2"
[9:22:11 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:22:11 AM] Finished query execution for document "untitled:Untitled-2"
[9:22:11 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:13 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-3".
[9:22:13 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-3". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:22:13 AM] Started query execution for document "untitled:Untitled-3"
[9:22:13 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:22:13 AM] Finished query execution for document "untitled:Untitled-3"
[9:22:13 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:15 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-4".
[9:22:15 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-4". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:22:15 AM] Started query execution for document "untitled:Untitled-4"
[9:22:15 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:22:15 AM] Finished query execution for document "untitled:Untitled-4"
[9:22:15 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:19 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-5".
[9:22:19 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-5". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:22:19 AM] Started query execution for document "untitled:Untitled-5"
[9:22:19 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:22:19 AM] Finished query execution for document "untitled:Untitled-5"
[9:22:19 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:22 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-6".
[9:22:22 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-6". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:22:22 AM] Started query execution for document "untitled:Untitled-6"
[9:22:22 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:22:22 AM] Finished query execution for document "untitled:Untitled-6"
[9:22:22 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:27 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:27 AM] Disconnected on document "untitled:Untitled-6"
[9:22:29 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:29 AM] Disconnected on document "untitled:Untitled-5"
[9:22:31 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:31 AM] Disconnected on document "untitled:Untitled-4"
[9:22:33 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:34 AM] Disconnected on document "untitled:Untitled-3"
[9:22:36 AM] [pgQueryResult] [All]: resultGrid: 14
[9:22:36 AM] Disconnected on document "untitled:Untitled-2"
[9:22:38 AM] Disconnected on document "untitled:Untitled-1"
[9:31:33 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-1".
[9:31:33 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-1". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:31:33 AM] Started query execution for document "untitled:Untitled-1"
[9:31:33 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:31:33 AM] Finished query execution for document "untitled:Untitled-1"
[9:31:34 AM] [pgQueryResult] [All]: resultGrid: 14
[9:31:34 AM] [pgQueryResult] [All]: QueryResultPane is ready to receive state updates
[9:31:34 AM] [pgQueryResult] [All]: Query result view is ready, checking queued state updates for 0 URIs
[9:31:34 AM] [pgQueryResult] [All]: Current active editor URI: untitled:Untitled-1
[9:31:34 AM] [pgQueryResult] [All]: resizeGrid - table is not initialized
[9:31:34 AM] [pgQueryResult] [All]: resultGrid: 14
[9:31:45 AM] Connecting to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-2".
[9:31:45 AM] Connected to server "REDACTED.postgres.database.azure.com" on document "untitled:Untitled-2". Server information: {"isCloud":true,"server":"PostgreSQL","serverVersion":"15.0.13"}
[9:31:45 AM] Started query execution for document "untitled:Untitled-2"
[9:31:45 AM] [pgQueryResult] [Verbose]: Adding result set summary for batchId: 0, resultId: 0
[9:31:45 AM] Finished query execution for document "untitled:Untitled-2"
[9:31:45 AM] [pgQueryResult] [All]: resultGrid: 14
[9:32:27 AM] [ObjectExplorerService] [All]: Getting children for node '/databases/33630591/schemas/33630850/tables/69353334/'
[9:33:29 AM] Disconnected on document "untitled:Untitled-2"
[9:33:31 AM] Disconnected on document "untitled:Untitled-1"
[9:33:39 AM] [connectionDialog] [All]: Connection to edit passed in with id: 81E2D8CA-3571-47AF-AD69-5510E8A8E14E and profile name: REDACTED
[9:33:39 AM] [connectionDialog] [All]: Initializing connection dialog
[9:33:39 AM] [PgToolsService Initialization] [Verbose]: readAllConnections: 1 connections (1 from config, 0 from recent))
[9:33:39 AM] [connectionDialog] [All]: Has connection to edit: true
[9:33:39 AM] [connectionDialog] [All]: Loading connection to edit
[9:33:39 AM] [PgToolsService Initialization] [Verbose]: Retreived 1 Azure accounts from account store.
[9:33:39 AM] [PgToolsService Initialization] [Verbose]: Retreived 1 Azure accounts from account store.
[9:33:39 AM] [PgToolsService Initialization] [Verbose]: Retreived 1 Azure accounts from account store.
[9:33:39 AM] [PgToolsService Initialization] [Verbose]: Retreived 1 Azure accounts from account store.

[mmcfarland]

Thanks for the report. The query editors are meant to release connections back into a shared pool for reuse. We'll look into this behavior to see why they seem to be persisted in this scenario.

[craftzneko]

Hi @mmcfarland has there been any update on this, at this point its unusable I have to go back to azure data studio which i know has a finite lifespan at this point, can I provide anything to help?

[mmcfarland]

Hi @craftzneko -- I've been able to reproduce this issue, and will be taking a look at it for the Feb release. Thanks for bringing it to our attention. I'll provide updates on this thread.

[mmcfarland]

Hi @craftzneko -- v1.15.0 has just been released to the marketplace, and it includes a fix which returns query-window connections back to the connection pool when the editor is closed. This is a pre-release version, so if you could opt-in and validate that the fix resolves your problem, I'd appreciate it!

[craftzneko]

@mmcfarland I switched to the pre release. Opened 10 select statements for different tables and watched my connection count climb and then closed each one and saw the connection count drop back to baseline a few seconds apart from each other so looks like this is working! Thank you!

[mmcfarland]

Great, really appreciate the report and the confirmation. Thanks @craftzneko!