Skip to content

GitHub Authentication Disregards github-enterprise.uri value #148621

Description

@zbs

I've searched high and low and have not found an answer on this

  • Extension version: v0.40.0
  • VSCode Version: 1.66.2
  • OS: Windows 10
  • Remote OS: Red Hat Enterprise Linux 7 (using Remote-SSH)

Steps to Reproduce:

  1. Set github-enterprise.url as follows:
"github-enterprise.uri": "https://git.w2k.domain.com"
  1. Run Publish to GitHub command
  2. Hit "OK" on prompt to authenticate GItHub

Expected Results:
https://git.w2k.domain.com is opened in my browser

Actual Result:
github.com is opened in my browser. Note that I am not seeing the option to authenticate my GitHub account after pressing the Accounts button on the bottom left.

Also note that I am seeing this output in Github Pull Request output pane:

[Info] Registering git provider
[Info] Looking for git repository
[Info] Found 1 repositories during activation
[Info] Git repository found, initializing review manager and pr tree view.
[Info] Review> Validate state in progress
[Info] Review> Validating state...
[Info] No remotes found. The following remotes are missing: origin, upstream
[Info] No GitHub remotes found
[Info] Review> Queuing additional validate state
[Info] Review> Validating state...
[Info] Found GitHub remote
[Info] Review> no matching pull request metadata found for current branch zs-athena-price-server
[Info] Review> no matching pull request metadata found on GitHub for current branch zs-athena-price-server

and am seeing this in Github Enterprise Authentication:

[Info  - 19:08:21.106] Reading sessions from keychain...
[Info  - 19:08:23.87] Getting sessions for read:user,repo,user:email...
[Info  - 19:08:23.87] Got 0 sessions for read:user,repo,user:email...

Earlier, it complained about no config file in my .ssh directory, so I created a blank one. I'm curious if that needs to be filled out correctly.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions