Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Added light, temperature and accelerometer on python side#196

Merged
vandyliu merged 22 commits intodevfrom
users/t-vali/light-temp-accel-sensors
Feb 12, 2020
Merged

Added light, temperature and accelerometer on python side#196
vandyliu merged 22 commits intodevfrom
users/t-vali/light-temp-accel-sensors

Conversation

@vandyliu
Copy link
Copy Markdown
Contributor

@vandyliu vandyliu commented Feb 10, 2020

Description:

Added light, temperature and accelerometer on python side

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vandyliu vandyliu requested a review from andreamah February 10, 2020 23:06
xnkevinnguyen
xnkevinnguyen reviewed Feb 10, 2020
View reviewed changes
Comment thread src/microbit/__model/display.py Outdated
andreamah
andreamah reviewed Feb 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks for all this work :D

Comment thread src/microbit/test/test_shim.py
Comment thread src/microbit/__model/microbit_model.py
Comment thread src/microbit/__model/accelerometer.py Outdated
@andreamah andreamah mentioned this pull request Feb 11, 2020
Merged
9 tasks
andreamah
andreamah approved these changes Feb 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :D

isadorasophia
isadorasophia approved these changes Feb 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏄

Comment thread src/microbit/__model/accelerometer.py
Comment thread src/microbit/__model/accelerometer.py
nasadigital
nasadigital approved these changes Feb 12, 2020
View reviewed changes
Copy link
Copy Markdown

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️⚡️⚡️

Comment thread src/microbit/test/test_microbit_model.py Outdated
@vandyliu vandyliu merged commit 2e4e326 into dev Feb 12, 2020
@vandyliu vandyliu deleted the users/t-vali/light-temp-accel-sensors branch February 12, 2020 03:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@abmahdy abmahdy Awaiting requested review from abmahdy abmahdy is a code owner

@adclements adclements Awaiting requested review from adclements adclements is a code owner

@iennae iennae Awaiting requested review from iennae

@markAtMicrosoft markAtMicrosoft Awaiting requested review from markAtMicrosoft

@sagarmanchanda sagarmanchanda Awaiting requested review from sagarmanchanda sagarmanchanda is a code owner

@smmatte smmatte Awaiting requested review from smmatte smmatte is a code owner

@xnkevinnguyen xnkevinnguyen Awaiting requested review from xnkevinnguyen

3 more reviewers

@isadorasophia isadorasophia isadorasophia approved these changes

@nasadigital nasadigital nasadigital approved these changes

@andreamah andreamah andreamah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vandyliu @isadorasophia @nasadigital @xnkevinnguyen @andreamah