Skip to content

Rethink modal dialog #232

@Tyriar

Description

@Tyriar

Testing #226

When changing the shellStartup setting we see this:

Image

I think the plan is to enable this by default so this isn't a good solution in the long run.

  • Should this be a notification with apply/do not ask again? Is there a better presentation we don't yet support in the extension API?
  • Should this only attempt to replace the terminal in question? You can get the shell via Terminal.creationOptions.shellPath ?? env.shell. I don't really want the python extension in VS Code to edit all my shell scripts or none of them.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions