-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Labels
Description
This should be disposable:
dispose's impl should be:
public dispose() {
if (this.timeout) {
clearTimeout(this.timeout);
}
}Not having this means that if the debouncer's job is done while the setTimeout is active, it will still fire again.
An example of this in practice is if the extension is disabled it should immediately dispose everything. Another example is the transient usage in #952