Enhance NativePythonFinderImpl with improved logging and configuration comparison#1149
Merged
karthiknadig merged 1 commit intomainfrom Feb 3, 2026
Merged
Enhance NativePythonFinderImpl with improved logging and configuration comparison#1149karthiknadig merged 1 commit intomainfrom
karthiknadig merged 1 commit intomainfrom
Conversation
Member
|
@copilot add testing for functionality introduced here and also to confirm the Cache Key Collision Prevention and Type Guard for isNativeEnvInfo() is working. |
Contributor
|
@eleanorjboyd I've opened a new pull request, #1151, to work on those changes. Once the pull request is ready, I'll request review from you. |
dmitrivMS
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements code quality improvements for
ativePythonFinder.tsas identified in #1142.Changes
1. Type Guard for
isNativeEnvInfo()Changed return type from
booleantoinfo is NativeEnvInfofor proper TypeScript type narrowing.2. Robust Configuration Comparison
Replaced fragile
JSON.stringify()comparison with a dedicatedconfigurationEquals()method that:3. Cache Key Collision Prevention
Changed the separator for cache keys from
,to\0(null character) to prevent collisions with paths containing commas.4. Standardized Logging
Converted
traceVerbosecalls withinNativePythonFinderImplto useoutputChannel.debug()for consistent instance-level logging. Removed unused import.5. Graceful Shutdown
Added a graceful shutdown mechanism that closes stdin before killing the process, giving it 500ms to clean up.
6. Documentation
Added explanatory comment for the intentional duplicate
venvFoldersfetch explaining why it's needed whensearchPathsmay overrideenvironmentDirectories.Fixes #1142