feat: enhance getVenvForWorkspace to prioritize persisted selections#1397
Merged
eleanorjboyd merged 2 commits intomicrosoft:mainfrom Mar 25, 2026
Merged
Conversation
…and handle stale paths
eleanorjboyd
added
the
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Updates getVenvForWorkspace() to prioritize the user’s persisted workspace venv selection over process.env.VIRTUAL_ENV, and adds unit tests to lock in the intended precedence and fallback behavior.
Changes:
- Reorders resolution logic to check persisted workspace selection before
VIRTUAL_ENV. - Clears stale persisted entries when the stored venv path no longer exists.
- Adds a unit test suite covering precedence, fallback, and stale data scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/managers/builtin/venvUtils.ts | Reorders venv selection priority and adds safer fallback logic for VIRTUAL_ENV. |
| src/test/managers/builtin/venvUtils.getVenvForWorkspace.unit.test.ts | Introduces tests verifying persisted selection precedence, VIRTUAL_ENV fallback, and stale entry cleanup. |
TylerLeonhardt
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getVenvForWorkspace()insrc/managers/builtin/venvUtils.ts](src/managers/builtin/venvUtils.ts#L64-L65unconditionally returnsprocess.env.VIRTUAL_ENVif set, ignoring the user's explicitly saved workspace selection. This PR switches that orderingfixes microsoft/vscode-python#25867