feat: add PET version and build ID telemetry properties to enhance performance tracking#1548
Draft
eleanorjboyd wants to merge 3 commits into
Draft
feat: add PET version and build ID telemetry properties to enhance performance tracking#1548eleanorjboyd wants to merge 3 commits into
eleanorjboyd wants to merge 3 commits into
Conversation
…rformance tracking
Contributor
There was a problem hiding this comment.
Pull request overview
This PR augments existing PET (Python Environment Tools) performance/health telemetry by fetching PET’s version/build identifier via a new info JSON-RPC call and attaching those properties to key PET events, enabling performance tracking across PET versions.
Changes:
- Add a fire-and-forget PET
inforequest and cache the response to stamp subsequent telemetry withpetVersion/petBuildId. - Include
petVersionandpetBuildIdproperties onpet.refresh,pet.resolve, andpet.process_restarttelemetry events. - Register the new telemetry properties in the GDPR mapping/types.
Show a summary per file
| File | Description |
|---|---|
| src/managers/common/nativePythonFinder.ts | Fetches/caches PET info and adds petVersion/petBuildId to PET telemetry payloads. |
| src/common/telemetry/constants.ts | Declares the new telemetry properties and adds GDPR metadata/type annotations for relevant PET events. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goes along with microsoft/python-environment-tools#470 to support getting PET versions as telemetry to track performance regression and improvements across specific version numbers