feat: package manager permissions when using API #218
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,11 @@ | ||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
| import { commands } from 'vscode'; | ||
| import { Disposable } from 'vscode-jsonrpc'; | ||
|
|
||
| export function executeCommand<T = unknown>(command: string, ...rest: any[]): Thenable<T> { | ||
| return commands.executeCommand(command, ...rest); | ||
| } | ||
|
|
||
| export function registerCommand(command: string, callback: (...args: any[]) => any, thisArg?: any): Disposable { | ||
| return commands.registerCommand(command, callback, thisArg); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| import { Uri } from 'vscode'; | ||
| import { ENVS_EXTENSION_ID, PYTHON_EXTENSION_ID } from '../constants'; | ||
| import { parseStack } from '../errors/utils'; | ||
| import { allExtensions, getExtension } from '../extension.apis'; | ||
| import { normalizePath } from './pathUtils'; | ||
| interface FrameData { | ||
| filePath: string; | ||
| functionName: string; | ||
|
|
@@ -15,38 +16,63 @@ function getFrameData(): FrameData[] { | |
| })); | ||
| } | ||
|
|
||
| function getPathFromFrame(frame: FrameData): string { | ||
| if (frame.filePath && frame.filePath.startsWith('file://')) { | ||
| return Uri.parse(frame.filePath).fsPath; | ||
| } | ||
| return frame.filePath; | ||
| } | ||
|
|
||
| export function getCallingExtension(): string { | ||
| const pythonExts = [ENVS_EXTENSION_ID, PYTHON_EXTENSION_ID]; | ||
| const extensions = allExtensions(); | ||
| const otherExts = extensions.filter((ext) => !pythonExts.includes(ext.id)); | ||
| const frames = getFrameData(); | ||
| const filePaths: string[] = []; | ||
|
|
||
| for (const frame of frames) { | ||
| if (!frame || !frame.filePath) { | ||
| continue; | ||
| } | ||
| const filePath = normalizePath(getPathFromFrame(frame)); | ||
| if (!filePath) { | ||
| continue; | ||
| } | ||
|
|
||
| if (filePath.toLowerCase().endsWith('extensionhostprocess.js')) { | ||
| continue; | ||
| } | ||
|
|
||
| if (filePath.startsWith('node:')) { | ||
| continue; | ||
| } | ||
|
|
||
| filePaths.push(filePath); | ||
|
|
||
| const ext = otherExts.find((ext) => filePath.includes(ext.id)); | ||
| if (ext) { | ||
| return ext.id; | ||
| } | ||
| } | ||
|
|
||
| // `ms-python.vscode-python-envs` extension in Development mode | ||
| const candidates = filePaths.filter((filePath) => | ||
| otherExts.some((s) => filePath.includes(normalizePath(s.extensionPath))), | ||
| ); | ||
| const envExt = getExtension(ENVS_EXTENSION_ID); | ||
|
|
||
| if (!envExt) { | ||
| throw new Error('Something went wrong with feature registration'); | ||
| } | ||
| const envsExtPath = normalizePath(envExt.extensionPath); | ||
| if (candidates.length === 0 && filePaths.every((filePath) => filePath.startsWith(envsExtPath))) { | ||
| return PYTHON_EXTENSION_ID; | ||
| } else if (candidates.length > 0) { | ||
| // 3rd party extension in Development mode | ||
| const candidateExt = otherExts.find((ext) => candidates[0].includes(ext.extensionPath)); | ||
| if (candidateExt) { | ||
| return candidateExt.id; | ||
| } | ||
| } | ||
|
|
||
| throw new Error('Unable to determine calling extension id, registration failed'); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| import { isWindows } from '../../managers/common/utils'; | ||
|
|
||
| export function normalizePath(path: string): string { | ||
| const path1 = path.replace(/\\/g, '/'); | ||
| if (isWindows()) { | ||
| return path1.toLowerCase(); | ||
| } | ||
| return path1; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,8 @@ import { | |
| InputBox, | ||
| InputBoxOptions, | ||
| LogOutputChannel, | ||
| MessageItem, | ||
| MessageOptions, | ||
| OpenDialogOptions, | ||
| OutputChannel, | ||
| Progress, | ||
|
|
@@ -284,10 +286,38 @@ export async function showInputBoxWithButtons( | |
| } | ||
| } | ||
|
|
||
| export function showWarningMessage<T extends string>(message: string, ...items: T[]): Thenable<T | undefined>; | ||
| export function showWarningMessage<T extends string>( | ||
| message: string, | ||
| options: MessageOptions, | ||
| ...items: T[] | ||
| ): Thenable<T | undefined>; | ||
| export function showWarningMessage<T extends MessageItem>(message: string, ...items: T[]): Thenable<T | undefined>; | ||
| export function showWarningMessage<T extends MessageItem>( | ||
| message: string, | ||
| options: MessageOptions, | ||
| ...items: T[] | ||
| ): Thenable<T | undefined>; | ||
| export function showWarningMessage(message: string, ...items: any[]): Thenable<string | undefined> { | ||
| return window.showWarningMessage(message, ...items); | ||
| } | ||
|
|
||
| export function showInformationMessage<T extends string>(message: string, ...items: T[]): Thenable<T | undefined>; | ||
| export function showInformationMessage<T extends string>( | ||
| message: string, | ||
| options: MessageOptions, | ||
| ...items: T[] | ||
| ): Thenable<T | undefined>; | ||
| export function showInformationMessage<T extends MessageItem>(message: string, ...items: T[]): Thenable<T | undefined>; | ||
| export function showInformationMessage<T extends MessageItem>( | ||
| message: string, | ||
| options: MessageOptions, | ||
| ...items: T[] | ||
| ): Thenable<T | undefined>; | ||
| export function showInformationMessage(message: string, ...items: any[]): Thenable<string | undefined> { | ||
| return window.showInformationMessage(message, ...items); | ||
| } | ||
|
|
||
| export function showInputBox(options?: InputBoxOptions, token?: CancellationToken): Thenable<string | undefined> { | ||
| return window.showInputBox(options, token); | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure "Ask" is easily understandable in this context. I wonder if we should do something like "Always Ask" or "Confirm each time" at the tradeoff of having a slightly longer button title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed- I also wanted this button to be explicit it was a long-term choice