Skip to content

Conversation

@eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Aug 21, 2025

fixes #686

@eleanorjboyd eleanorjboyd self-assigned this Aug 21, 2025
scaffolding for pipenv as an env manager
@vs-code-engineering vs-code-engineering bot added this to the August 2025 milestone Aug 21, 2025
eleanorjboyd and others added 3 commits August 21, 2025 16:28
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive support for Pipenv virtual environment management to the Python environments extension. It introduces functionality to discover, manage, and resolve Pipenv environments similar to existing support for Conda, Poetry, and Pyenv.

  • Implements complete Pipenv environment discovery and management through a new PipenvManager class
  • Adds utility functions for Pipenv path resolution, caching, and workspace/global environment persistence
  • Integrates Pipenv support into the main extension activation flow

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/managers/pipenv/pipenvUtils.ts Core utility functions for Pipenv path discovery, environment conversion, and persistence management
src/managers/pipenv/pipenvManager.ts Main PipenvManager class implementing the EnvironmentManager interface for full Pipenv support
src/managers/pipenv/main.ts Registration function to initialize Pipenv features and integrate with the extension
src/extension.ts Extension activation updates to register Pipenv features alongside other environment managers
src/common/localize.ts Localized strings for Pipenv-related UI messages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@eleanorjboyd
Copy link
Member Author

@cwebster-99 what documentation do I need to update alongside this?

@cwebster-99
Copy link
Member

cwebster-99 commented Aug 22, 2025

@eleanorjboyd the README.md is our current source of truth. It doesn't look to be updated to include any of the basic support manager (poetry, pipenv, pyenv). We can make a pass at updating the table in the Features section. Let me know if you would want to do that in this PR or I can create a separate one!

@eleanorjboyd
Copy link
Member Author

ill create a separate PR but can add it

@eleanorjboyd eleanorjboyd merged commit d6fcd29 into main Aug 22, 2025
10 checks passed
@eleanorjboyd eleanorjboyd deleted the adding-pipenv-support branch August 22, 2025 17:24
eleanorjboyd added a commit that referenced this pull request Sep 15, 2025
NguyenCuong1989 referenced this pull request in NguyenCuong1989/vscode-python-environments Oct 23, 2025
fixes microsoft/vscode-python-environments#686

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add basic pipenv support

4 participants