-
Notifications
You must be signed in to change notification settings - Fork 29
Adding pipenv support #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
scaffolding for pipenv as an env manager
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
f8ce44c to
5f92aad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive support for Pipenv virtual environment management to the Python environments extension. It introduces functionality to discover, manage, and resolve Pipenv environments similar to existing support for Conda, Poetry, and Pyenv.
- Implements complete Pipenv environment discovery and management through a new PipenvManager class
- Adds utility functions for Pipenv path resolution, caching, and workspace/global environment persistence
- Integrates Pipenv support into the main extension activation flow
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/managers/pipenv/pipenvUtils.ts | Core utility functions for Pipenv path discovery, environment conversion, and persistence management |
| src/managers/pipenv/pipenvManager.ts | Main PipenvManager class implementing the EnvironmentManager interface for full Pipenv support |
| src/managers/pipenv/main.ts | Registration function to initialize Pipenv features and integrate with the extension |
| src/extension.ts | Extension activation updates to register Pipenv features alongside other environment managers |
| src/common/localize.ts | Localized strings for Pipenv-related UI messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@cwebster-99 what documentation do I need to update alongside this? |
|
@eleanorjboyd the README.md is our current source of truth. It doesn't look to be updated to include any of the basic support manager (poetry, pipenv, pyenv). We can make a pass at updating the table in the Features section. Let me know if you would want to do that in this PR or I can create a separate one! |
|
ill create a separate PR but can add it |
This reverts commit d6fcd29.
fixes microsoft/vscode-python-environments#686 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
fixes #686