Better handle terminal shell integration check #915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzhao271
approved these changes
Oct 8, 2025
anthonykim1
added a commit
that referenced
this pull request
Oct 9, 2025
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python-environments
that referenced
this pull request
Oct 9, 2025
This would incur less notification for change in user profile rather try to wait for shell integration not too long(max 0.5 second, but more commonly earlier since shell integration would be ready before then), we were already taking similar approach in some part of the code, but not all.
eleanorjboyd
pushed a commit
to eleanorjboyd/vscode-python-environments
that referenced
this pull request
Oct 9, 2025
Resolves: microsoft#919 which will improve on top of microsoft#915 I want to bulletproof shell startup as much as possible. We shouldn't be showing profile modification prompt if user has shell integration. We should also ensure proper clean up.
eleanorjboyd
added a commit
that referenced
this pull request
Oct 9, 2025
Resolves: #919 which will improve on top of #915 I want to bulletproof shell startup as much as possible. We shouldn't be showing profile modification prompt if user has shell integration. We should also ensure proper clean up. --------- Co-authored-by: Anthony Kim <62267334+anthonykim1@users.noreply.github.com>
NguyenCuong1989
referenced
this pull request
in NguyenCuong1989/vscode-python-environments
Oct 23, 2025
This would incur less notification for change in user profile rather try to wait for shell integration not too long(max 0.5 second, but more commonly earlier since shell integration would be ready before then), we were already taking similar approach in some part of the code, but not all.
NguyenCuong1989
pushed a commit
to NguyenCuong1989/vscode-python-environments
that referenced
this pull request
Oct 23, 2025
Resolves: microsoft/vscode-python-environments#919 which will improve on top of microsoft/vscode-python-environments#915 I want to bulletproof shell startup as much as possible. We shouldn't be showing profile modification prompt if user has shell integration. We should also ensure proper clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would incur less notification for change in user profile rather try to wait for shell integration not too long(max 0.5 second, but more commonly earlier since shell integration would be ready before then), we were already taking similar approach in some part of the code, but not all.