Skip to content

Conversation

@anthonykim1
Copy link
Contributor

@anthonykim1 anthonykim1 commented Oct 9, 2025

Resolves: #919 which will improve on top of #915

I want to bulletproof shell startup as much as possible.
We shouldn't be showing profile modification prompt if user has shell integration.

We should also ensure proper clean up.

@anthonykim1 anthonykim1 added this to the October 2025 milestone Oct 9, 2025
@anthonykim1 anthonykim1 self-assigned this Oct 9, 2025
@anthonykim1 anthonykim1 marked this pull request as ready for review October 9, 2025 07:07
@anthonykim1 anthonykim1 merged commit 72f4aa8 into main Oct 9, 2025
12 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/referShellIntegrationSetting branch October 9, 2025 07:20
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python-environments that referenced this pull request Oct 9, 2025
Resolves:
microsoft#919 which
will improve on top of
microsoft#915

I want to bulletproof shell startup as much as possible. 
We shouldn't be showing profile modification prompt if user has shell
integration.

We should also ensure proper clean up.
NguyenCuong1989 referenced this pull request in NguyenCuong1989/vscode-python-environments Oct 23, 2025
Resolves:
microsoft/vscode-python-environments#919 which
will improve on top of
microsoft/vscode-python-environments#915

I want to bulletproof shell startup as much as possible. 
We shouldn't be showing profile modification prompt if user has shell
integration.

We should also ensure proper clean up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bash with shell integration on triggers .bashrc update with shellStartup

3 participants