Skip to content

fix: missing & when running PET command #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

fix: missing & when running PET command #968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import { normalizePath } from './common/utils/pathUtils';
import { isWindows } from './common/utils/platformUtils';
import { createTerminal, showInputBoxWithButtons } from './common/window.apis';
import { getConfiguration } from './common/workspace.apis';
import { ShellConstants } from './features/common/shellConstants';
import { identifyTerminalShell } from './features/common/shellDetector';
import { quoteArgs } from './features/execution/execUtils';
import { getAutoActivationType } from './features/terminal/utils';
import { EnvironmentManagers, PythonProjectManager } from './internal.api';
import { getNativePythonToolsPath, NativeEnvInfo, NativePythonFinder } from './managers/common/nativePythonFinder';
Expand Down Expand Up @@ -182,7 +185,19 @@ export async function runPetInTerminalImpl(): Promise<void> {
terminal.show();

// Run pet find --verbose
terminal.sendText(`"${petPath}" find --verbose`, true);
const shellType = identifyTerminalShell(terminal);
const executable = petPath;
const args = ['find', '--verbose'];
if (terminal.shellIntegration) {
// use shell integration if available
terminal.shellIntegration.executeCommand(executable, args);
} else {
let text = quoteArgs([executable, ...args]).join(' ');
if (shellType === ShellConstants.PWSH && !text.startsWith('&')) {
text = `& ${text}`;
}
terminal.sendText(text, true);
}
traceInfo(`Running PET find command: ${petPath} find --verbose`);
} else if (selectedOption.label === 'Resolve Environment...') {
try {
Expand All @@ -209,7 +224,18 @@ export async function runPetInTerminalImpl(): Promise<void> {
terminal.show();

// Run pet resolve with the provided path
terminal.sendText(`"${petPath}" resolve "${inputPath.trim()}"`, true);
const shellType = identifyTerminalShell(terminal);
const executable = petPath;
const args = ['resolve', inputPath.trim()];
if (terminal.shellIntegration) {
terminal.shellIntegration.executeCommand(executable, args);
} else {
let text = quoteArgs([executable, ...args]).join(' ');
if (shellType === ShellConstants.PWSH && !text.startsWith('&')) {
text = `& ${text}`;
}
terminal.sendText(text, true);
}
traceInfo(`Running PET resolve command: ${petPath} resolve "${inputPath.trim()}"`);
}
} catch (ex) {
Expand Down
Loading