'terminal.integrated.shell.windows' of workspace is ignored by python launcher

[Hoshino-Roxy]

Environment data

• VS Code version: 1.44.0
• Extension version (available under the Extensions sidebar): 2020.3.71659
• OS and version: Windows 10 ver.1909
• Python version (& distribution if applicable, e.g. Anaconda): 3.7.7
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): venv
• Relevant/affected Python packages and their versions: (None)
• Relevant/affected Python-related VS Code extensions and their versions: (None)
• Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info How to update the language server to the latest stable version #3977): True
• Value of the python.languageServer setting: Microsoft

Expected behaviour

If 'terminal.integrated.shell.windows' is set in XXX.code-workspace file, it overrides the same value of user level setting.

Actual behaviour

Python launches on 'terminal.integrated.shell.windows' of user setting, and it ignores 'terminal.integrated.shell.windows' of workspace setting.

Steps to reproduce:

1. Set workspace
   Create test.code-workspace as the following;

{
	"folders": [
		{
			"path": "."
		}
	],
	"settings": {
		"terminal.integrated.shell.windows": "${env:SystemRoot}\\system32\\cmd.exe"
	}
}

2. Open this workspace from menu [Open Workspace]

3. Open terminal (i.e. [Ctrl]+[j])

Command Prompt is opened.

Select [Allow], if VSC shows the message about 'Terminal change'.

4. Change default terminal to PowerShell in terminal menu 'Select Default Shell'

5. Open terminal again (i.e. [+] button of terminal window top)

Command Prompt is opened.

6. Open python code on editor and start debug (i.e. [F5])

Python launches on PowerShell

[ericsnowcurrently]

@Hoshino-Roxy, thanks for letting us know about this. Sorry about the delay. Functionality related to the shell is handled by VS Code. The Python extension is not involved. It only uses the configuration to determine how to build commands to send to the terminal. So you will need to open a new issue upstream.

Before you do that, I just want to see what info the Python extension captured for this. Please provide the contents of the "Python" output panel, as well as the "Developer Tools" console log (Console under the Developer Tools panel; toggle Developer Tools on under Help).

Also, just so we're clear on how settings get resolved, the VS Code API docs have a good explanation.

[Zin758]

Thanks for your reply.
I have no time right now, we will check it and reply to you in a few days.

[Hoshino-Roxy]

This problem have been fixed the following version:

• VS Code version: 1.45.1
• Extension version (available under the Extensions sidebar): 2020.5.78807

Thanks for the improvement!

[Hoshino-Roxy]

I made a mistake in the confirmation method.
This problem have not been fixed yet.

[Hoshino-Roxy]

This is console logs:
console_log.zip

• ps_launch_vsc.log : Launch VSC, default condle is PowerShell
• cmd_launch_vsc.log : Launch VSC, default condle is cmd
• ps_debug_python.log : Start debug python script, default condle is PowerShell
• cmd_debug_python.log : Start debug python script, default condle is cmd
• change_shell_cmd2ps.log : Change default script from cmd to PowerShell