Use the vscode API appropriately to find out what terminal is being used

[karrtikr]

Change this method

vscode-python/src/client/common/terminal/shellDetectors/vscEnvironmentShellDetector.ts

Lines 24 to 30 in db8e1e2

	public identify(
	telemetryProperties: ShellIdentificationTelemetry,
	_terminal?: Terminal,
	): TerminalShellType | undefined {
	if (!this.appEnv.shell) {
	return;
	}

To get the active shell , we need to read from terminal.creationOptions.shellPath first, and if it's not set, fallback on vscode.env.shell API. Otherwise, wrong activation commands are sent when opening terminal using the icon,

Solution discussed in upstream VSCode issue microsoft/vscode#127374