Use VSCode API appropriately to find out what terminal is being used #16858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
changed the title
karthiknadig
reviewed
Aug 3, 2021
| ): TerminalShellType | undefined { | ||
| if (!this.appEnv.shell) { | ||
| const shellPath = | ||
| terminal?.creationOptions && 'shellPath' in terminal.creationOptions && terminal.creationOptions.shellPath |
Member
There was a problem hiding this comment.
Suggested change
| terminal?.creationOptions && 'shellPath' in terminal.creationOptions && terminal.creationOptions.shellPath | |
| terminal?.creationOptions && terminal.creationOptions.shellPath |
Shouldn't that just work? if a field is not defined on an object, it is just returns undefined.
Author
There was a problem hiding this comment.
Nope, atleast not for the type check compiler.
shellPath property doesn't exist on type of terminal.creationOptions (which is Readonly<TerminalOptions | ExtensionTerminalOptions>), so we have to narrow down the type first to Readonly<TerminalOptions> using this.
karthiknadig
approved these changes
Aug 3, 2021
Author
|
@karthiknadig If you find everything okay can you also merge this PR as I mentioned here #16858 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16577 closes https://github.com/microsoft/vscode-python-internalbacklog/issues/342
@karthiknadig Please merge this after reviewing as no one else is available to review.