Skip to content

Test against Python 3.9#14303

Merged
brettcannon merged 1 commit intomicrosoft:mainfrom
brettcannon:test-against-3.9
Oct 16, 2020
Merged

Test against Python 3.9#14303
brettcannon merged 1 commit intomicrosoft:mainfrom
brettcannon:test-against-3.9

Conversation

@brettcannon
Copy link
Copy Markdown
Member

No description provided.

@brettcannon brettcannon added the no-changelog No news entry required label Oct 7, 2020
@brettcannon brettcannon closed this Oct 7, 2020
@brettcannon brettcannon reopened this Oct 7, 2020
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IanMatthewHuff
Copy link
Copy Markdown
Member

@brettcannon will this include the Data Science functional tests? I don't believe that we can do that update yet, as there are still 3.9 ipykernel support issues like this one https://app.zenhub.com/workspaces/vscode-python-5a1de248bb238e1c6364bb56/issues/microsoft/vscode-python/14274.

@brettcannon brettcannon marked this pull request as draft October 8, 2020 18:00
@brettcannon
Copy link
Copy Markdown
Member Author

@IanMatthewHuff yes it would.

I have converted this back to draft. Please ping this PR once you are ready for 3.9 (which was released this week FYI).

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 8, 2020

Codecov Report

Merging #14303 into main will decrease coverage by 1.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14303      +/-   ##
==========================================
- Coverage   59.91%   58.67%   -1.25%     
==========================================
  Files         709      717       +8     
  Lines       39334    42545    +3211     
  Branches     5698     6532     +834     
==========================================
+ Hits        23567    24963    +1396     
- Misses      14529    16247    +1718     
- Partials     1238     1335      +97     
Impacted Files Coverage Δ
...c/client/pythonEnvironments/common/windowsUtils.ts 20.68% <0.00%> (-79.32%) ⬇️
...nt/datascience/notebookStorage/vscNotebookModel.ts 39.49% <0.00%> (-18.40%) ⬇️
src/client/datascience/notebook/contentProvider.ts 44.00% <0.00%> (-7.17%) ⬇️
...ascience/jupyter/liveshare/hostJupyterExecution.ts 52.38% <0.00%> (-5.60%) ⬇️
src/client/datascience/common.ts 55.33% <0.00%> (-4.91%) ⬇️
...atascience/notebookStorage/nativeEditorProvider.ts 14.21% <0.00%> (-3.06%) ⬇️
src/client/common/application/notebook.ts 8.04% <0.00%> (-2.87%) ⬇️
src/client/datascience/commands/exportCommands.ts 13.00% <0.00%> (-2.16%) ⬇️
src/client/datascience/export/exportUtil.ts 11.59% <0.00%> (-1.97%) ⬇️
...ascience/jupyter/liveshare/guestJupyterNotebook.ts 7.51% <0.00%> (-1.78%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4659f46...b3ab471. Read the comment docs.

@brettcannon brettcannon reopened this Oct 16, 2020
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IanMatthewHuff
Copy link
Copy Markdown
Member

Thanks for waiting. Should be good now.

@brettcannon brettcannon marked this pull request as ready for review October 16, 2020 19:32
@brettcannon brettcannon merged commit 02e4631 into microsoft:main Oct 16, 2020
@brettcannon brettcannon deleted the test-against-3.9 branch October 16, 2020 19:32
luabud pushed a commit to luabud/vscode-python that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants