Skip to content

Fix nyc compile error#14402

Merged
joyceerhl merged 1 commit intomainfrom
nyc-fix
Oct 14, 2020
Merged

Fix nyc compile error#14402
joyceerhl merged 1 commit intomainfrom
nyc-fix

Conversation

@joyceerhl
Copy link
Copy Markdown

For #14401

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@joyceerhl joyceerhl added the no-changelog No news entry required label Oct 14, 2020
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 14, 2020

Codecov Report

Merging #14402 into main will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #14402      +/-   ##
==========================================
- Coverage   59.40%   59.40%   -0.01%     
==========================================
  Files         716      716              
  Lines       39999    39999              
  Branches     5793     5793              
==========================================
- Hits        23763    23762       -1     
- Misses      14975    14976       +1     
  Partials     1261     1261              
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 68.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1370b6d...61cf2cf. Read the comment docs.

@joyceerhl joyceerhl requested a review from brettcannon October 14, 2020 19:17
@joyceerhl joyceerhl merged commit e001a0a into main Oct 14, 2020
@joyceerhl joyceerhl deleted the nyc-fix branch October 14, 2020 20:27
luabud pushed a commit to luabud/vscode-python that referenced this pull request Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants