Implement global virtual environment locator#14416
Merged
karthiknadig merged 13 commits intomicrosoft:mainfrom Oct 22, 2020
Merged
Implement global virtual environment locator#14416karthiknadig merged 13 commits intomicrosoft:mainfrom
karthiknadig merged 13 commits intomicrosoft:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14416 +/- ##
==========================================
+ Coverage 59.18% 59.29% +0.10%
==========================================
Files 720 719 -1
Lines 40216 40315 +99
Branches 5830 5849 +19
==========================================
+ Hits 23803 23903 +100
Misses 15151 15151
+ Partials 1262 1261 -1
Continue to review full report at Codecov.
|
karrtikr
suggested changes
Oct 16, 2020
karrtikr
reviewed
Oct 16, 2020
karrtikr
reviewed
Oct 16, 2020
int19h
reviewed
Oct 19, 2020
int19h
reviewed
Oct 19, 2020
int19h
reviewed
Oct 19, 2020
int19h
reviewed
Oct 19, 2020
int19h
reviewed
Oct 19, 2020
int19h
approved these changes
Oct 19, 2020
karrtikr
reviewed
Oct 19, 2020
karrtikr
reviewed
Oct 19, 2020
karrtikr
reviewed
Oct 19, 2020
karrtikr
reviewed
Oct 21, 2020
karrtikr
reviewed
Oct 21, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
karrtikr
approved these changes
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I consolidated a bunch of different virtual environment identifiers and locators. There was some clean up and code moved around. but the bulk of the changes are in GlobalVirtualEnvironment*.ts files.