Skip to content

Port dataviewer feature#14435

Merged
rchiodo merged 2 commits intorelease-2020.10from
port-dataviewer
Oct 19, 2020
Merged

Port dataviewer feature#14435
rchiodo merged 2 commits intorelease-2020.10from
port-dataviewer

Conversation

@joyceerhl
Copy link
Copy Markdown

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #14435 into release-2020.10 will decrease coverage by 0.21%.
The diff coverage is 29.37%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release-2020.10   #14435      +/-   ##
===================================================
- Coverage            59.40%   59.19%   -0.22%     
===================================================
  Files                  716      720       +4     
  Lines                39999    40211     +212     
  Branches              5793     5828      +35     
===================================================
+ Hits                 23763    23802      +39     
- Misses               14975    15147     +172     
- Partials              1261     1262       +1     
Impacted Files Coverage Δ
...cience/data-viewing/jupyterVariableDataProvider.ts 14.00% <0.00%> (ø)
...data-viewing/jupyterVariableDataProviderFactory.ts 50.00% <0.00%> (ø)
...active-common/intellisense/intellisenseProvider.ts 33.24% <0.00%> (ø)
...ience/interactive-common/interactiveWindowTypes.ts 100.00% <ø> (ø)
src/client/datascience/jupyter/jupyterVariables.ts 27.77% <0.00%> (ø)
src/client/datascience/types.ts 100.00% <ø> (ø)
src/client/telemetry/index.ts 80.41% <ø> (ø)
...rc/client/datascience/jupyter/debuggerVariables.ts 8.21% <6.66%> (ø)
.../datascience/interactive-common/interactiveBase.ts 5.93% <16.66%> (+0.15%) ⬆️
...atascience/interactive-common/dataViewerChecker.ts 20.83% <20.83%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f66dc0...47054ec. Read the comment docs.

@joyceerhl joyceerhl closed this Oct 19, 2020
@joyceerhl joyceerhl reopened this Oct 19, 2020
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rchiodo rchiodo merged commit 2971ac5 into release-2020.10 Oct 19, 2020
@rchiodo rchiodo deleted the port-dataviewer branch October 19, 2020 18:48
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 29.37063% with 101 lines in your changes missing coverage. Please review.
✅ Project coverage is 59%. Comparing base (7f66dc0) to head (47054ec).

Files with missing lines Patch % Lines
...rc/client/datascience/jupyter/debuggerVariables.ts 6% 42 Missing ⚠️
...atascience/interactive-common/dataViewerChecker.ts 20% 19 Missing ⚠️
src/client/datascience/commands/commandRegistry.ts 34% 15 Missing ⚠️
...cience/data-viewing/jupyterVariableDataProvider.ts 0% 7 Missing ⚠️
src/client/datascience/jupyter/jupyterVariables.ts 0% 7 Missing ⚠️
.../datascience/interactive-common/interactiveBase.ts 16% 5 Missing ⚠️
src/client/datascience/debugLocationTracker.ts 83% 0 Missing and 4 partials ⚠️
...data-viewing/jupyterVariableDataProviderFactory.ts 0% 1 Missing ⚠️
...active-common/intellisense/intellisenseProvider.ts 0% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-2020.10   #14435    +/-   ##
=================================================
- Coverage               59%      59%    -1%     
=================================================
  Files                  716      720     +4     
  Lines                39999    40211   +212     
  Branches              5793     5828    +35     
=================================================
+ Hits                 23763    23802    +39     
- Misses               14975    15147   +172     
- Partials              1261     1262     +1     
Files with missing lines Coverage Δ
src/client/datascience/constants.ts 99% <100%> (+<1%) ⬆️
...ience/interactive-common/interactiveWindowTypes.ts 100% <ø> (ø)
src/client/datascience/types.ts 100% <ø> (ø)
src/client/telemetry/index.ts 80% <ø> (ø)
...data-viewing/jupyterVariableDataProviderFactory.ts 50% <0%> (ø)
...active-common/intellisense/intellisenseProvider.ts 33% <0%> (ø)
src/client/datascience/debugLocationTracker.ts 76% <83%> (-2%) ⬇️
.../datascience/interactive-common/interactiveBase.ts 5% <16%> (+<1%) ⬆️
...cience/data-viewing/jupyterVariableDataProvider.ts 14% <0%> (ø)
src/client/datascience/jupyter/jupyterVariables.ts 27% <0%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants