Add pyenv locator#14587
Merged
karthiknadig merged 9 commits intomicrosoft:mainfrom Nov 4, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14587 +/- ##
==========================================
+ Coverage 64.90% 65.07% +0.17%
==========================================
Files 541 541
Lines 25144 25377 +233
Branches 3545 3587 +42
==========================================
+ Hits 16320 16515 +195
- Misses 8162 8179 +17
- Partials 662 683 +21
Continue to review full report at Codecov.
|
int19h
reviewed
Nov 2, 2020
int19h
reviewed
Nov 2, 2020
int19h
reviewed
Nov 2, 2020
int19h
reviewed
Nov 2, 2020
int19h
reviewed
Nov 2, 2020
int19h
reviewed
Nov 2, 2020
int19h
reviewed
Nov 2, 2020
karrtikr
reviewed
Nov 2, 2020
karrtikr
reviewed
Nov 2, 2020
int19h
approved these changes
Nov 3, 2020
karthiknadig
added
no-changelog
karrtikr
reviewed
Nov 4, 2020
| let specificity = getPythonVersionSpecificity(version); | ||
| for (const v of pythonVersions) { | ||
| if (v) { | ||
| const curSpecificity = getPythonVersionSpecificity(v); |
There was a problem hiding this comment.
Can you use comparePythonVersionSpecificity and not export getPythonVersionSpecificity at all?
There was a problem hiding this comment.
getPythonVersionSpecificity is still being exported.
| .map((p) => allParsers.get(p)) | ||
| .filter((p) => p !== undefined); | ||
|
|
||
| if (parsers.length > 0 && parsers[0]) { |
There was a problem hiding this comment.
Suggested change
| if (parsers.length > 0 && parsers[0]) { | |
| if (parsers.length > 0) { |
Will this work?
Member
Author
There was a problem hiding this comment.
Nope. Even though we filter out undefined, TS thinks that parsers[0] can be undefined.
There was a problem hiding this comment.
If you use the .map as I suggested above you should be able to get rid of parsers[0] check.
karrtikr
reviewed
Nov 4, 2020
karrtikr
approved these changes
Nov 4, 2020
| * Wn > Wn-1 + Wn-2 + ... W0 | ||
| */ | ||
| function getPythonVersionInfoHeuristic(version: PythonVersion): number { | ||
| export function getPythonVersionSpecificity(version: PythonVersion): number { |
| const parsers = knownPrefixes | ||
| .filter((k) => str.startsWith(k)) | ||
| .map((p) => allParsers.get(p)) | ||
| .filter((p) => p !== undefined); |
There was a problem hiding this comment.
Suggested change
| .filter((p) => p !== undefined); | |
| .filter((p) => p !== undefined); | |
| .map((p) => p!); |
There was a problem hiding this comment.
@karthiknadig However small the comments are, I expect them to be resolved or replied to before merging, when I do approve.
| .map((p) => allParsers.get(p)) | ||
| .filter((p) => p !== undefined); | ||
|
|
||
| if (parsers.length > 0 && parsers[0]) { |
There was a problem hiding this comment.
If you use the .map as I suggested above you should be able to get rid of parsers[0] check.
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.