Use forEach() w/ an accumulator over reduce() with an ignored return value#14817
Merged
brettcannon merged 2 commits intomicrosoft:mainfrom Nov 25, 2020
Merged
Use forEach() w/ an accumulator over reduce() with an ignored return value#14817brettcannon merged 2 commits intomicrosoft:mainfrom
brettcannon merged 2 commits intomicrosoft:mainfrom
Conversation
…value Sonar reports this as a bug since it's ignoring a return value in a situation where you don't _have_ to use a reduction/fold.
Prettier was installed, but VS Code didn't run it due to having more than one formatter installed thanks to the built-in one.
kimadeline
approved these changes
Nov 25, 2020
karrtikr
approved these changes
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://sonarcloud.io/project/issues?id=microsoft_vscode-python&open=AW2NhZqiw9ui8M2LaitJ&resolved=false&types=BUG