Fix code coverage upload#14821
Merged
kimadeline merged 19 commits intomicrosoft:mainfrom Nov 25, 2020
Merged
Conversation
added 14 commits
November 24, 2020 15:45
Codecov Report
@@ Coverage Diff @@
## main #14821 +/- ##
=======================================
Coverage 64% 65%
=======================================
Files 547 550 +3
Lines 25616 25916 +300
Branches 3619 3673 +54
=======================================
+ Hits 16622 16871 +249
- Misses 8314 8352 +38
- Partials 680 693 +13
|
brettcannon
approved these changes
Nov 25, 2020
Member
brettcannon
left a comment
There was a problem hiding this comment.
One tweak to pull in prior to merge, but otherwise LGTM!
Co-authored-by: Brett Cannon <brett@python.org>
karrtikr
approved these changes
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #14815
Insiders upload:
microsoft/vscode-python, do we want want to change this for code coverage to be uploaded for all PRs?package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).