Add experimentation support to node LS proxy#14897
Merged
jakebailey merged 2 commits intomicrosoft:mainfrom Dec 7, 2020
Merged
Add experimentation support to node LS proxy#14897jakebailey merged 2 commits intomicrosoft:mainfrom
jakebailey merged 2 commits intomicrosoft:mainfrom
Conversation
jakebailey
commented
Dec 4, 2020
|
|
||
| protected async getInitializationOptions() { | ||
| return { | ||
| experimentationSupport: true |
Member
Author
There was a problem hiding this comment.
This works like an LSP capability for backwards/forwards compatibility between things.
Member
Author
There was a problem hiding this comment.
Oops, so this got merged in #14896. I should have been more careful.
jakebailey
commented
Dec 4, 2020
jakebailey
changed the title
jakebailey
changed the title
jakebailey
changed the title
Member
Author
|
Not sure why the CI is failing for all Python 2. |
karrtikr
reviewed
Dec 7, 2020
karrtikr
left a comment
karrtikr
left a comment
There was a problem hiding this comment.
Can you please verify all relevant tests pass locally before merging?
Member
Author
|
The tests pass for me. Thanks for the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #14895
Includes #14896 (shame there's no GitHub equivalent to a gerrit CL stack...). Will mark as not draft after that is merged.
Not sure if this deserves a news entry in "enhancements" or not.
Has telemetry for enhancements.Unit tests & system/integration tests are added/updated.(Tested against pylance)Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).The wiki is updated with any design decisions/details.