Skip to content

Send telemetry when an interpreter was selected, or the quickpick dismissed#15223

Merged
kimadeline merged 4 commits intomicrosoft:mainfrom
kimadeline:telemetry-env-selection
Jan 26, 2021
Merged

Send telemetry when an interpreter was selected, or the quickpick dismissed#15223
kimadeline merged 4 commits intomicrosoft:mainfrom
kimadeline:telemetry-env-selection

Conversation

@kimadeline
Copy link
Copy Markdown

@kimadeline kimadeline commented Jan 25, 2021

The shouldResume property of multiStepInput was used nowhere, and was preventing us from returning undefined when the quickpick gets dismissed, so I removed it.

@kimadeline kimadeline self-assigned this Jan 25, 2021
@kimadeline kimadeline added the no-changelog No news entry required label Jan 25, 2021
@kimadeline kimadeline marked this pull request as ready for review January 25, 2021 18:13
@github-actions github-actions Bot requested review from int19h and karrtikr January 25, 2021 18:13
Copy link
Copy Markdown

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kimadeline kimadeline merged commit 4d539ba into microsoft:main Jan 26, 2021
@kimadeline kimadeline deleted the telemetry-env-selection branch January 26, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants