Fail on cancellation signal when providing TensorBoard codelenses #15332
Merged
joyceerhl merged 1 commit intomicrosoft:mainfrom Feb 8, 2021
joyceerhl:joyceerhl/cancel-token
Merged
Fail on cancellation signal when providing TensorBoard codelenses #15332joyceerhl merged 1 commit intomicrosoft:mainfrom joyceerhl:joyceerhl/cancel-token
joyceerhl merged 1 commit intomicrosoft:mainfrom
joyceerhl:joyceerhl/cancel-token
Conversation
joyceerhl
requested review from
DavidKutu,
DonJayamanne,
IanMatthewHuff,
karthiknadig and
rchiodo
DavidKutu
approved these changes
Feb 8, 2021
karthiknadig
approved these changes
Feb 8, 2021
Author
|
@karthiknadig should I be concerned about the failing tests on this PR? I believe they're all covered by #15328 |
Member
|
@joyceerhl Nope. You can merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure we fail when cancellation is signaled. Alternatively could've done this as a
Cancellation.racealthough I didn't think that was appropriate since computing the codelenses is not async.