Skip to content

Move ShowExtensionSurveyPrompt experiment to ExP#15693

Merged
kimadeline merged 3 commits intomicrosoft:mainfrom
kimadeline:15530-move-ShowExtensionSurveyPrompt-to-exp
Mar 18, 2021
Merged

Move ShowExtensionSurveyPrompt experiment to ExP#15693
kimadeline merged 3 commits intomicrosoft:mainfrom
kimadeline:15530-move-ShowExtensionSurveyPrompt-to-exp

Conversation

@kimadeline
Copy link
Copy Markdown

For #15530

Note that we explicitly don't migrate people who opted in/out of the old experiment.

@kimadeline kimadeline added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating labels Mar 17, 2021
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 17, 2021

Codecov Report

Merging #15693 (c3c5dd5) into main (c7fea18) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##            main   #15693   +/-   ##
======================================
- Coverage     64%      64%   -1%     
======================================
  Files        557      557           
  Lines      26814    26812    -2     
  Branches    3901     3901           
======================================
- Hits       17366    17364    -2     
  Misses      8714     8714           
  Partials     734      734           
Impacted Files Coverage Δ
src/client/activation/extensionSurvey.ts 95% <100%> (-1%) ⬇️
src/client/common/experiments/groups.ts 100% <100%> (ø)
src/client/common/experiments/manager.ts 85% <100%> (ø)

@kimadeline kimadeline marked this pull request as ready for review March 18, 2021 15:07
@kimadeline kimadeline merged commit 573dd98 into microsoft:main Mar 18, 2021
@kimadeline kimadeline deleted the 15530-move-ShowExtensionSurveyPrompt-to-exp branch March 18, 2021 19:29
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64%. Comparing base (c7fea18) to head (c3c5dd5).
⚠️ Report is 2303 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #15693   +/-   ##
======================================
- Coverage     64%      64%   -1%     
======================================
  Files        557      557           
  Lines      26814    26812    -2     
  Branches    3901     3901           
======================================
- Hits       17366    17364    -2     
  Misses      8714     8714           
  Partials     734      734           
Files with missing lines Coverage Δ
src/client/activation/extensionSurvey.ts 95% <100%> (-1%) ⬇️
src/client/common/experiments/groups.ts 100% <100%> (ø)
src/client/common/experiments/manager.ts 85% <100%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants