Skip to content

Conversation

@DonJayamanne
Copy link

Fixes #1856

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@DonJayamanne DonJayamanne requested a review from brettcannon June 4, 2018 20:39
@DonJayamanne DonJayamanne added this to the May 2018 milestone Jun 4, 2018
@codecov
Copy link

codecov bot commented Jun 4, 2018

Codecov Report

Merging #1858 into master will increase coverage by 0.14%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
+ Coverage   74.29%   74.44%   +0.14%     
==========================================
  Files         282      282              
  Lines       13189    13209      +20     
  Branches     2371     2374       +3     
==========================================
+ Hits         9799     9833      +34     
+ Misses       3258     3244      -14     
  Partials      132      132
Impacted Files Coverage Δ
src/client/providers/symbolProvider.ts 82% <89.47%> (+58.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7459ab...5e3dadc. Read the comment docs.

@DonJayamanne DonJayamanne deleted the issue1856ThrottleSymbolProvider branch June 4, 2018 22:51
@DonJayamanne DonJayamanne restored the issue1856ThrottleSymbolProvider branch June 4, 2018 22:51
@DonJayamanne DonJayamanne reopened this Jun 5, 2018
@DonJayamanne DonJayamanne merged commit 1b281d5 into microsoft:master Jun 5, 2018
@DonJayamanne DonJayamanne deleted the issue1856ThrottleSymbolProvider branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throttle output from symbol provider

2 participants