Skip to content

Improve discovery resolving API#18729

Merged
karrtikr merged 3 commits intomicrosoft:mainfrom
karrtikr:resolvenfc
Mar 21, 2022
Merged

Improve discovery resolving API#18729
karrtikr merged 3 commits intomicrosoft:mainfrom
karrtikr:resolvenfc

Conversation

@karrtikr
Copy link
Copy Markdown

@karrtikr karrtikr commented Mar 21, 2022 •
edited
Loading

For #18815

  • Make it more resilient so it doesn't fail with error. For eg. if an invalid path is set.
  • Highlight in the documentation that full path needs to be passed to the API and fix usage.
  • Improve public discovery API documentation.

@karrtikr karrtikr added no-changelog No news entry required skip tests Updates to tests unnecessary labels Mar 21, 2022
@karrtikr karrtikr added this to the March 2022 milestone Mar 21, 2022
@karrtikr karrtikr removed the skip tests Updates to tests unnecessary label Mar 21, 2022
@karrtikr karrtikr merged commit 787fa5a into microsoft:main Mar 21, 2022
@karrtikr karrtikr deleted the resolvenfc branch March 21, 2022 14:52
@karrtikr karrtikr mentioned this pull request Apr 7, 2022
Closed
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@wesm
Improve discovery resolving API (microsoft/vscode-python#18729)
c4a94eb 
* Improve discovery resolving API

* Improve public api doc

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@karrtikr karrtikr

Labels

no-changelog No news entry required

Projects

None yet

Milestone

March 2022

Development

Successfully merging this pull request may close these issues.

1 participant

@karrtikr