Update webpack for browser to polyfill process.#19033
Merged
karthiknadig merged 4 commits intomicrosoft:mainfrom Apr 29, 2022
Merged
Update webpack for browser to polyfill process.#19033karthiknadig merged 4 commits intomicrosoft:mainfrom
karthiknadig merged 4 commits intomicrosoft:mainfrom
Conversation
karthiknadig
added
no-changelog
|
|
karthiknadig
commented
Apr 28, 2022
Comment on lines
+46
to
+48
| // Attempt to load from the vscode locale. If not there, use english | ||
| const vscodeConfigString = process.env.VSCODE_NLS_CONFIG; | ||
| return vscodeConfigString ? JSON.parse(vscodeConfigString).locale : 'en-us'; |
Member
Author
There was a problem hiding this comment.
@kimadeline I am reverting this to how it was before I made the try--catch to capture the ReferenceError on vscode.dev
karthiknadig
commented
Apr 28, 2022
| "nock": "^10.0.6", | ||
| "node-has-native-dependencies": "^1.0.2", | ||
| "node-loader": "^1.0.2", | ||
| "node-polyfill-webpack-plugin": "^1.1.4", |
Member
Author
There was a problem hiding this comment.
@kimadeline Thanks for the tip on this. This was the solution for the ReferenceError problem.
kimadeline
approved these changes
Apr 28, 2022
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…hon#19033) * Update webpack for browser to polyfill process. * Use node polyfill webpack plugin * Revert webpack config changes * Revert "Handle `process` usage in browser scenario. (microsoft/vscode-python#19029)" This reverts commit e786d6286942dc519c17aea8f1e43f003e6e00b4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.