Skip to content

Make LSP notebooks event also trigger for those who may be on the control group #19194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luabud merged 1 commit into from
May 25, 2022
Merged

Make LSP notebooks event also trigger for those who may be on the control group #19194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/client/activation/node/lspNotebooksExperiment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ export class LspNotebooksExperiment implements IExtensionSingleActivationService
this.isInExperiment = false;
if (languageServerType !== LanguageServerType.Node) {
traceLog(`LSP Notebooks experiment is disabled -- not using Pylance`);
} else if (!isInTreatmentGroup) {
traceLog(`LSP Notebooks experiment is disabled -- not in treatment group`);
} else if (!LspNotebooksExperiment.isJupyterInstalled()) {
traceLog(`LSP Notebooks experiment is disabled -- Jupyter disabled or not installed`);
} else if (!LspNotebooksExperiment.jupyterSupportsNotebooksExperiment()) {
Expand All @@ -76,12 +74,14 @@ export class LspNotebooksExperiment implements IExtensionSingleActivationService
traceLog(`LSP Notebooks experiment is disabled -- Pylance disabled or not installed`);
} else if (!LspNotebooksExperiment.pylanceSupportsNotebooksExperiment()) {
traceLog(`LSP Notebooks experiment is disabled -- Pylance does not support experiment`);
} else if (!isInTreatmentGroup) {
traceLog(`LSP Notebooks experiment is disabled -- not in treatment group`);
// to avoid scorecard SRMs, we're also triggering the telemetry for users who meet
// the criteria to experience LSP notebooks, but may be in the control group.
sendTelemetryEvent(EventName.PYTHON_EXPERIMENTS_LSP_NOTEBOOKS);
} else {
this.isInExperiment = true;
traceLog(`LSP Notebooks experiment is enabled`);
}

if (this.isInExperiment) {
sendTelemetryEvent(EventName.PYTHON_EXPERIMENTS_LSP_NOTEBOOKS);
}

Expand Down