Skip to content

Enable multi-threaded tests for experimental debugger#1935

Merged
DonJayamanne merged 1 commit intomicrosoft:masterfrom
DonJayamanne:issue1250MultiThreadedDebug
Jun 12, 2018
Merged

Enable multi-threaded tests for experimental debugger#1935
DonJayamanne merged 1 commit intomicrosoft:masterfrom
DonJayamanne:issue1250MultiThreadedDebug

Conversation

@DonJayamanne
Copy link
Copy Markdown

Fixes #1250

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

Copy link
Copy Markdown

@d3r3kk d3r3kk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple...

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 12, 2018

Codecov Report

Merging #1935 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1935      +/-   ##
==========================================
- Coverage   74.35%   74.28%   -0.07%     
==========================================
  Files         283      283              
  Lines       13287    13287              
  Branches     2387     2387              
==========================================
- Hits         9879     9870       -9     
- Misses       3273     3278       +5     
- Partials      135      139       +4
Impacted Files Coverage Δ
src/client/debugger/PythonProcess.ts 45.83% <0%> (-2.09%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 52.96% <0%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a614bc...86afee6. Read the comment docs.

@DonJayamanne DonJayamanne merged commit c5db6c6 into microsoft:master Jun 12, 2018
@DonJayamanne DonJayamanne deleted the issue1250MultiThreadedDebug branch June 20, 2018 03:13
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Experimental debugger fails to stop at breakpoint on CI server (multi-threaded code)

2 participants