Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 27 additions & 27 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -920,12 +920,6 @@
"scope": "machine-overridable",
"type": "string"
},
"python.pylanceLspNotebooksEnabled": {
"type": "boolean",
"default": true,
"description": "%python.pylanceLspNotebooksEnabled.description%",
"scope": "machine"
},
"python.sortImports.args": {
"default": [],
"description": "%python.sortImports.args.description%",
Expand Down Expand Up @@ -1797,7 +1791,7 @@
"webpack": "webpack"
},
"dependencies": {
"@vscode/jupyter-lsp-middleware": "^0.2.46",
"@vscode/jupyter-lsp-middleware": "^0.2.50",
"@vscode/extension-telemetry": "^0.6.2",
"arch": "^2.1.0",
"diff-match-patch": "^1.0.0",
Expand Down
1 change: 0 additions & 1 deletion package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@
"python.logging.level.description": "The logging level the extension logs at, defaults to 'error'",
"python.pipenvPath.description": "Path to the pipenv executable to use for activation.",
"python.poetryPath.description": "Path to the poetry executable.",
"python.pylanceLspNotebooksEnabled.description": "Determines if Pylance's experimental LSP notebooks support is used or not.",
"python.sortImports.args.description": "Arguments passed in. Each argument is a separate item in the array.",
"python.sortImports.path.description": "Path to isort script, default using inner version",
"python.tensorBoard.logDirectory.description": "Set this setting to your preferred TensorBoard log directory to skip log directory prompt when starting TensorBoard.",
Expand Down
2 changes: 1 addition & 1 deletion src/client/activation/node/lspNotebooksExperiment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export class LspNotebooksExperiment implements IExtensionSingleActivationService

private updateExperimentSupport(): void {
const wasInExperiment = this.isInExperiment;
const isInTreatmentGroup = this.configurationService.getSettings().pylanceLspNotebooksEnabled;
const isInTreatmentGroup = true;
const languageServerType = this.configurationService.getSettings().languageServer;

this.isInExperiment = false;
Expand Down
3 changes: 0 additions & 3 deletions src/client/common/configSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ export class PythonSettings implements IPythonSettings {

public globalModuleInstallation = false;

public pylanceLspNotebooksEnabled = false;

public experiments!: IExperiments;

public languageServer: LanguageServerType = LanguageServerType.Node;
Expand Down Expand Up @@ -313,7 +311,6 @@ export class PythonSettings implements IPythonSettings {
}

this.globalModuleInstallation = pythonSettings.get<boolean>('globalModuleInstallation') === true;
this.pylanceLspNotebooksEnabled = pythonSettings.get<boolean>('pylanceLspNotebooksEnabled') === true;

const sortImportSettings = systemVariables.resolveAny(pythonSettings.get<ISortImportSettings>('sortImports'))!;
if (this.sortImports) {
Expand Down
1 change: 0 additions & 1 deletion src/client/common/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ export interface IPythonSettings {
readonly sortImports: ISortImportSettings;
readonly envFile: string;
readonly globalModuleInstallation: boolean;
readonly pylanceLspNotebooksEnabled: boolean;
readonly experiments: IExperiments;
readonly languageServer: LanguageServerType;
readonly languageServerIsDefault: boolean;
Expand Down