Skip to content

Fix pre-release platform specific build number #23684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karthiknadig merged 1 commit into from
Jun 25, 2024
Merged

Fix pre-release platform specific build number #23684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build/azure-pipeline.pre-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ extends:
parameters:
publishExtension: ${{ parameters.publishExtension }}
ghCreateTag: false
standardizedVersioning: true
l10nSourcePaths: ./src/client
sourceRepositoriesToScan:
include:
Expand Down Expand Up @@ -103,8 +104,8 @@ extends:
- script: nox --session install_python_libs
displayName: Install Jedi, get-pip, etc

- script: python ./build/update_ext_version.py --for-publishing
displayName: Update build number
# - script: python ./build/update_ext_version.py --for-publishing
# displayName: Update build number

- script: python ./build/update_package_file.py
displayName: Update telemetry in package.json
Expand Down
4 changes: 1 addition & 3 deletions build/update_ext_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,7 @@ def main(package_json: pathlib.Path, argv: Sequence[str]) -> None:
if args.build_id:
# If build id is provided it should fall within the 0-INT32 max range
# that the max allowed value for publishing to the Marketplace.
if args.build_id < 0 or (
args.for_publishing and args.build_id > ((2**32) - 1)
):
if args.build_id < 0 or (args.for_publishing and args.build_id > ((2**32) - 1)):
raise ValueError(f"Build ID must be within [0, {(2**32) - 1}]")

package["version"] = ".".join((major, minor, str(args.build_id)))
Expand Down