Skip to content

Do not throw error in launch.json does not exist#4536

Merged
DonJayamanne merged 1 commit intomicrosoft:masterfrom
DonJayamanne:fixDebuggingOfTests
Feb 26, 2019
Merged

Do not throw error in launch.json does not exist#4536
DonJayamanne merged 1 commit intomicrosoft:masterfrom
DonJayamanne:fixDebuggingOfTests

Conversation

@DonJayamanne
Copy link
Copy Markdown

For #332

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [n/a] Has a news entry file (remember to thank yourself!)
  • [n/a] Has sufficient logging.
  • [n/a] Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 26, 2019
Copy link
Copy Markdown

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2019

Codecov Report

Merging #4536 into master will increase coverage by 21%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #4536     +/-   ##
========================================
+ Coverage      58%     78%    +21%     
========================================
  Files         367     443     +76     
  Lines       15786   20858   +5072     
  Branches     2461    3363    +902     
========================================
+ Hits         9052   16152   +7100     
+ Misses       6142    4701   -1441     
+ Partials      592       5    -587
Flag Coverage Δ
#Linux 66% <34%> (?)
#Windows 66% <34%> (?)
#macOS 66% <34%> (?)

@DonJayamanne DonJayamanne merged commit a41f77d into microsoft:master Feb 26, 2019
@DonJayamanne DonJayamanne deleted the fixDebuggingOfTests branch May 24, 2019 20:21
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants