Skip to content

Fix shift enter when cell are defined#4541

Merged
IanMatthewHuff merged 32 commits intomicrosoft:masterfrom
IanMatthewHuff:dev/ianhu/shiftEnterCells
Feb 26, 2019
Merged

Fix shift enter when cell are defined#4541
IanMatthewHuff merged 32 commits intomicrosoft:masterfrom
IanMatthewHuff:dev/ianhu/shiftEnterCells

Conversation

@IanMatthewHuff
Copy link
Copy Markdown
Member

For #4413

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2019

Codecov Report

Merging #4541 into master will increase coverage by 5%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #4541     +/-   ##
========================================
+ Coverage      58%     63%     +5%     
========================================
  Files         367     443     +76     
  Lines       15789   20860   +5071     
  Branches     2462    3363    +901     
========================================
+ Hits         9129   12948   +3819     
- Misses       6047    7907   +1860     
+ Partials      613       5    -608
Flag Coverage Δ
#Windows 46% <ø> (?)

@IanMatthewHuff IanMatthewHuff merged commit 287b3e5 into microsoft:master Feb 26, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/shiftEnterCells branch July 25, 2019 23:49
@lock lock Bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants