Skip to content

Fix context menus to not run cell commands twice#4544

Merged
rchiodo merged 2 commits intomasterfrom
rchiodo/fix_context
Feb 26, 2019
Merged

Fix context menus to not run cell commands twice#4544
rchiodo merged 2 commits intomasterfrom
rchiodo/fix_context

Conversation

@rchiodo
Copy link
Copy Markdown

@rchiodo rchiodo commented Feb 26, 2019

For #4532

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@rchiodo rchiodo self-assigned this Feb 26, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2019

Codecov Report

Merging #4544 into master will increase coverage by 20%.
The diff coverage is 80%.

@@           Coverage Diff            @@
##           master   #4544     +/-   ##
========================================
+ Coverage      58%     78%    +20%     
========================================
  Files         367     443     +76     
  Lines       15789   20879   +5090     
  Branches     2462    3372    +910     
========================================
+ Hits         9129   16165   +7036     
+ Misses       6047    4707   -1340     
+ Partials      613       7    -606
Flag Coverage Δ
#Linux 66% <20%> (?)
#Windows 66% <20%> (?)
#macOS 65% <20%> (?)

@rchiodo rchiodo merged commit 827467f into master Feb 26, 2019
@rchiodo rchiodo deleted the rchiodo/fix_context branch February 26, 2019 02:06
rchiodo added a commit that referenced this pull request Feb 26, 2019
* Fix issue with id not being passed in on context menus

* Add news entry
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants