Support other data types for DataViewer#5093
Merged
Conversation
Beginning of functional test
| export const noRowsInDataViewer = localize('DataScience.noRowsInDataViewer', 'Fetching data ...'); | ||
| export const pandasTooOldForViewingFormat = localize('DataScience.pandasTooOldForViewingFormat', 'Python package \'pandas\' is version {0}. Version 0.20 or greater is required for viewing data.'); | ||
| export const pandasRequiredForViewing = localize('DataScience.pandasRequiredForViewing', 'Python package \'pandas\' is required for viewing data.'); | ||
| export const valuesColumn = localize('DataScience.valuesColumn', 'values'); |
Member
There was a problem hiding this comment.
Or actually looks like you are just using as a constant. Just a constant then?
In reply to: 271822249 [](ancestors = 271822249)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #4677
Add code for other data types
Add new functional tests for those data types
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)