Skip to content

Allow self signed certs on jupyter remote connections#6003

Merged
IanMatthewHuff merged 11 commits intomicrosoft:masterfrom
IanMatthewHuff:dev/ianhu/selfCerts2
Jun 13, 2019
Merged

Allow self signed certs on jupyter remote connections#6003
IanMatthewHuff merged 11 commits intomicrosoft:masterfrom
IanMatthewHuff:dev/ianhu/selfCerts2

Conversation

@IanMatthewHuff
Copy link
Copy Markdown
Member

For #4987

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • [] Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@IanMatthewHuff IanMatthewHuff requested a review from rchiodo June 12, 2019 23:58
@IanMatthewHuff IanMatthewHuff changed the title Dev/ianhu/self certs2 Allow self signed certs on jupyter remote connections Jun 12, 2019
// This should already have been parsed when set, so just throw if it's not right here
throw err;
}
const settings = this.configuration.getSettings();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could detect when this is necessary and ask the user at that point?

rchiodo
rchiodo previously approved these changes Jun 13, 2019
Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo dismissed their stale review June 13, 2019 17:52

revoking review

Copy link
Copy Markdown

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@IanMatthewHuff IanMatthewHuff merged commit e0feb53 into microsoft:master Jun 13, 2019
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/selfCerts2 branch June 13, 2019 19:57
@atulkakrana
Copy link
Copy Markdown

How do I use/test this patch?

@IanMatthewHuff
Copy link
Copy Markdown
Member Author

@atulkakrana I added some instructions on the last post of the issue here:
https://github.com/microsoft/vscode-python/issues/4987

Basically you have to install our point development build and change the Allow Unauthorized Remote Connection VSCode setting to true.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants