Lowercase drive letter on localhost path mappings on Windows#6023
Merged
kimadeline merged 5 commits intomicrosoft:masterfrom Jun 14, 2019
Merged
Lowercase drive letter on localhost path mappings on Windows#6023kimadeline merged 5 commits intomicrosoft:masterfrom
kimadeline merged 5 commits intomicrosoft:masterfrom
Conversation
added 3 commits
June 13, 2019 15:23
DonJayamanne
approved these changes
Jun 14, 2019
src/test/debugger/extension/configuration/resolvers/attach.unit.test.ts
Outdated
Show resolved
Hide resolved
src/test/debugger/extension/configuration/resolvers/attach.unit.test.ts
Outdated
Show resolved
Hide resolved
DonJayamanne
approved these changes
Jun 14, 2019
DonJayamanne
left a comment
There was a problem hiding this comment.
Please add the additional tests before merging.
src/test/debugger/extension/configuration/resolvers/attach.unit.test.ts
Outdated
Show resolved
Hide resolved
DonJayamanne
approved these changes
Jun 14, 2019
|
@kimadeline You can instead use |
Author
|
Good point, I'll move the test(`Ensure drive letter is lower cased for local path mappings on Windows when host is '${host}'`, async () => {
if (os.name === 'Windows') {
this.skip();
}
// test code
}); |
|
Remember:
test(`Ensure drive letter is lower cased for local path mappings on Windows when host is '${host}'`, async function (){
if (os.name === 'Windows') {
return this.skip();
}
// test code
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #5362
Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.