Skip to content

Fix python test in news folder #6398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonJayamanne merged 2 commits into from
Jul 1, 2019
Merged

Fix python test in news folder #6398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab54bba
Fix broken python tests in news
DonJayamanne Jul 1, 2019
70aa311
Revert changes
DonJayamanne Jul 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion news/announce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ def complete_news(version, entry, previous_news):
title, _, previous_news = previous_news.partition("\n")
title = title.strip()
previous_news = previous_news.strip()
section_title = f"## {version} ({datetime.date.today().strftime('%d %B %Y')})"
section_title = (f"## {version} ({datetime.date.today().strftime('%d %B %Y')})"
).replace("(0", "(")
# TODO: Insert the "Thank you!" section (in monthly releases)?
return f"{title}\n\n{section_title}\n\n{entry.strip()}\n\n\n{previous_news}"

Expand Down
3 changes: 2 additions & 1 deletion news/test_announce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,8 @@ def fake_git_rm(path):

def test_complete_news():
version = "2019.3.0"
date = datetime.date.today().strftime("%d %B %Y")
# Remove leading `0`.
date = datetime.date.today().strftime("%d %B %Y").lstrip("0")
news = ann.complete_news(version, NEW_NEWS, f"{TITLE}\n\n\n{OLD_NEWS}")
expected = f"{TITLE}\n\n## {version} ({date})\n\n{NEW_NEWS.strip()}\n\n\n{OLD_NEWS.strip()}"
assert news == expected
Expand Down