Skip to content

Conversation

@DavidKutu
Copy link

if the user is already in the bottom, like a chat window.

For #6580

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

if the user is already in the bottom, like a chat window.
@DavidKutu DavidKutu self-assigned this Aug 8, 2019
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

David Kutugata added 2 commits August 8, 2019 16:36
snaps to the bottom when creating multiple
default plots. The user needs to scroll a bit from
the bottom to prevent the window to scroll all the way.
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DavidKutu DavidKutu merged commit b674db6 into master Aug 12, 2019
@DavidKutu DavidKutu deleted the davidkutu/interactive_window_snapps_to_bottom branch August 12, 2019 16:19
@janosh
Copy link

janosh commented Aug 15, 2019

I'm experiencing unexpected behavior with this. Even when the window is fully at the bottom, many outputs are large enough (I presume) that it will not be close enough at the bottom to stick there once that output has been printed. Perhaps we could increase the margin at which the window will keep snapping to the bottom?

@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
@DavidKutu
Copy link
Author

I'm experiencing unexpected behavior with this. Even when the window is fully at the bottom, many outputs are large enough (I presume) that it will not be close enough at the bottom to stick there once that output has been printed. Perhaps we could increase the margin at which the window will keep snapping to the bottom?

Hi @janosh I'll be checking this today. Do you by any chance have the code that's generating the large output? Is it a large plot?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants